[GitHub] [spark] sleep1661 edited a comment on pull request #33872: [SPARK-36575][CORE] Should ignore task finished event if its task set is gone in TaskSchedulerImpl.handleSuccessfulTask

[GitBox <gi...@apache.org>]

sleep1661 edited a comment on pull request #33872:
URL: https://github.com/apache/spark/pull/33872#issuecomment-964229552


   > Regarding "There was a race condition issues here, which will make TaskSetManager.successful and TaskSetManager.tasksSuccessful inconsistent." in the PR description, could you explain more? It's been a while since the last time I looked into this issue, and I currently can't see how `successful` and `tasksSuccessful` become inconsistent.
   
   You can take a look at my unit test. Without my PR, the `tasksSuccessful` will become  `1` and `successful`  will be `true`
   
   BTW, I modified the PR description.  Maybe "inconsistent"  was not a correct description.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org