You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/17 11:53:13 UTC

[jira] [Commented] (CXF-6161) wsdl2java can use invalid local filename when working with wsdl imports

    [ https://issues.apache.org/jira/browse/CXF-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249702#comment-14249702 ] 

ASF GitHub Bot commented on CXF-6161:
-------------------------------------

GitHub user escabe opened a pull request:

    https://github.com/apache/cxf/pull/43

    Fix for [CXF-6161]

    Instead of using a local filename based on the original URL of an
    wsdl:import use a numbered name: importNN.wsdl. Similar to schema
    imports. This should resolve issue [CXF-6161] in which an invalid
    filename may be generated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/escabe/cxf 2.7.x-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit a9c9baea404cb79ff7555ae325bc46d74544eb1c
Author: Martijn Aben <ma...@mathworks.nl>
Date:   2014-12-17T10:48:29Z

    Fix for [CXF-6161]
    
    Instead of using a local filename based on the original URL of an
    wsdl:import use a numbered name: importNN.wsdl. Similar to schema
    imports. This should resolve issue [CXF-6161] in which an invalid
    filename may be generated.

----


> wsdl2java can use invalid local filename when working with wsdl imports
> -----------------------------------------------------------------------
>
>                 Key: CXF-6161
>                 URL: https://issues.apache.org/jira/browse/CXF-6161
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.7.14
>         Environment: Windows platform
>            Reporter: Martijn Aben
>
> When using wsdl2java on an WSDL which has an wsdl import like:
> <wsdl:import namespace="http://tempuri.org/MyService/ExternalWSDL" location="http://localhost/WebApplication1/WebService1.asmx?wsdl=wsdl1"/>
> WSDLToJavaContainer.generateLocalWSDL tries to create a temporary file on disk named "WebService1.asmx?wsdl=wsdl1" on Windows this is an invalid filename due to the question mark (?).
> I have a proposed solution for this: just like with schema imports simply use a numbered file on disk importNN.wsdl. I will be submitting a pull request for this soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)