You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/06 08:29:39 UTC

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4173: Call setWasNull in GroupByStreamMergedResult

tuohai666 commented on issue #4173: Call setWasNull in GroupByStreamMergedResult
URL: https://github.com/apache/incubator-shardingsphere/pull/4173#issuecomment-582791411
 
 
   @plazmdk  You are right. GroupByStreamMergedResult overwrite the getValue() method but miss set the wasNull value.
   Can you fix the code conventions above in ShardingSphere(https://shardingsphere.apache.org/community/en/contribute/code-conduct/)?
   I thinks this pr is also applicated to the master branch. Can you submit another more pr to master?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services