You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (Created) (JIRA)" <ji...@apache.org> on 2011/11/04 18:11:51 UTC
[jira] [Created] (BOOKKEEPER-107) memory leak in HostAddress of
hedwig c++ client
memory leak in HostAddress of hedwig c++ client
-----------------------------------------------
Key: BOOKKEEPER-107
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-107
Project: Bookkeeper
Issue Type: Bug
Components: hedwig-client
Affects Versions: 3.4.0
Reporter: Sijie Guo
Fix For: 4.0.0
should use freeaddrinfo to free struct addrinfo, instead of using free directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-107) memory leak in HostAddress of
hedwig c++ client
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146436#comment-13146436 ]
Ivan Kelly commented on BOOKKEEPER-107:
---------------------------------------
lgtm +1
> memory leak in HostAddress of hedwig c++ client
> -----------------------------------------------
>
> Key: BOOKKEEPER-107
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-107
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-107.patch
>
>
> should use freeaddrinfo to free struct addrinfo, instead of using free directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-107) memory leak in HostAddress of
hedwig c++ client
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146445#comment-13146445 ]
Hudson commented on BOOKKEEPER-107:
-----------------------------------
Integrated in bookkeeper-trunk #207 (See [https://builds.apache.org/job/bookkeeper-trunk/207/])
BOOKKEEPER-107: memory leak in HostAddress of hedwig c++ client (Sijie Guo via ivank)
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/clientimpl.cpp
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/clientimpl.h
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/util.cpp
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/util.h
> memory leak in HostAddress of hedwig c++ client
> -----------------------------------------------
>
> Key: BOOKKEEPER-107
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-107
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-107.patch
>
>
> should use freeaddrinfo to free struct addrinfo, instead of using free directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-107) memory leak in HostAddress of
hedwig c++ client
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146439#comment-13146439 ]
Ivan Kelly commented on BOOKKEEPER-107:
---------------------------------------
Oh, one thing. When you generate patches with git, use --no-prefix. When I set up automatic patch testing, it'll be required for the patch to apply.
> memory leak in HostAddress of hedwig c++ client
> -----------------------------------------------
>
> Key: BOOKKEEPER-107
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-107
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-107.patch
>
>
> should use freeaddrinfo to free struct addrinfo, instead of using free directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-107) memory leak in HostAddress of
hedwig c++ client
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-107:
---------------------------------
Attachment: BOOKKEEPER-107.patch
attach a patch:
1) use freeaddrinfo instead of free
2) remove socket_addr from HostAddress, since we just need to keep ip and port.
3) in clientimpl, it is not necessary to parse address from string each time creating channel. just parse it once when clientimpl initializes and keep it in variable defaultHost which could be used directly when creating channels.
> memory leak in HostAddress of hedwig c++ client
> -----------------------------------------------
>
> Key: BOOKKEEPER-107
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-107
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-107.patch
>
>
> should use freeaddrinfo to free struct addrinfo, instead of using free directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira