You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/12 04:39:09 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
HyukjinKwon opened a new pull request #32517:
URL: https://github.com/apache/spark/pull/32517
### What changes were proposed in this pull request?
This PR fixes the same issue as https://github.com/apache/spark/pull/32424
```r
df <- sql("SELECT array(1, 2, 3) as numbers, array('a', 'b', 'c') as letters")
collect(select(
df,
array_transform("numbers", function(number) {
array_transform("letters", function(latter) {
struct(alias(number, "n"), alias(latter, "l"))
})
})
))
```
**Before:**
```
transform(numbers, lambdafunction(transform(letters, lambdafunction(struct(namedlambdavariable() AS n, namedlambdavariable() AS l), namedlambdavariable())), namedlambdavariable()))
1 a, a, b, b, c, c, a, a, b, b, c, c, a, a, b, b, c, c
```
**After:**
```
transform(numbers, lambdafunction(transform(letters, lambdafunction(struct(namedlambdavariable() AS n, namedlambdavariable() AS l), namedlambdavariable())), namedlambdavariable()))
1 1, a, 1, b, 1, c, 2, a, 2, b, 2, c, 3, a, 3, b, 3, c
```
### Why are the changes needed?
To produce the correct results.
### Does this PR introduce _any_ user-facing change?
Yes, it fixes the results to be correct as mentioned above.
### How was this patch tested?
Manually tested as above, and unit test was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32517:
URL: https://github.com/apache/spark/pull/32517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839493311
**[Test build #138431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138431/testReport)** for PR 32517 at commit [`67e4b98`](https://github.com/apache/spark/commit/67e4b98e3a05eb9ca8d2313fa49e0213b57566a7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839491672
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138426/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839497325
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42947/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839475701
**[Test build #138426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138426/testReport)** for PR 32517 at commit [`f17b074`](https://github.com/apache/spark/commit/f17b074c8c5d1e22f87e4b92523f1ceff37b7bff).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839549861
Merged to master and branch-3.1!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839451396
**[Test build #138426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138426/testReport)** for PR 32517 at commit [`f17b074`](https://github.com/apache/spark/commit/f17b074c8c5d1e22f87e4b92523f1ceff37b7bff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839497287
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42947/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839451396
**[Test build #138426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138426/testReport)** for PR 32517 at commit [`f17b074`](https://github.com/apache/spark/commit/f17b074c8c5d1e22f87e4b92523f1ceff37b7bff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839491672
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138426/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839497325
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42947/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839515617
**[Test build #138431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138431/testReport)** for PR 32517 at commit [`67e4b98`](https://github.com/apache/spark/commit/67e4b98e3a05eb9ca8d2313fa49e0213b57566a7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839493311
**[Test build #138431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138431/testReport)** for PR 32517 at commit [`67e4b98`](https://github.com/apache/spark/commit/67e4b98e3a05eb9ca8d2313fa49e0213b57566a7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839427517
cc @maropu @zero323 @ueshin FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839492739
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42947/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839529065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839529065
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138431/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839529172
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42952/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839529206
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42952/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32517: [SPARK-35381][R] Fix lambda variable name issues in nested higher order functions at R APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32517:
URL: https://github.com/apache/spark/pull/32517#issuecomment-839525302
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42952/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org