[GitHub] [iceberg] bryanck commented on pull request #4958: Shutdown refresh token executor service during REST catalog client close

[GitBox <gi...@apache.org>]

bryanck commented on PR #4958:
URL: https://github.com/apache/iceberg/pull/4958#issuecomment-1146805796

   The way it is now is similar to the shutdown in `RewriteDataFilesCommitManager.java`.
   
   One minor thing is that the client is being closed before the executor is shut down, so any refresh tasks in progress will most likely fail. Awaiting termination might not be that useful. The refreshed token isn't going to be used if the catalog is being closed AFAIK. Alternatively, closing the client could come after the awaitTermination if that's a concern.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org