You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2026/10/27 21:26:46 UTC
[PR] build(ffi): forward the spill-rocksdb feature through hudi-jvm-ffi [hudi-rs]
yihua opened a new pull request, #849:
URL: https://github.com/apache/hudi-rs/pull/849
## Description
The C ABI crate takes `hudi` with its defaults, so a consumer of `hudi-jvm-ffi` gets the merge map's on-disk tier (`spill-rocksdb`, and with it RocksDB, bindgen and libclang) with no way to opt out, since a consumer can only drop a feature its direct dependency exposes. This forwards the feature the way `hudi-datafusion` and `hudi` already do: `default = ["spill-rocksdb"]`, `spill-rocksdb = ["hudi/spill-rocksdb"]`, and `hudi` taken with `default-features = false`. Default builds are unchanged; a consumer that wants the tier gone builds the crate with `--no-default-features`.
The `no-spill-backend` CI job now checks the crate without the feature and includes it in the `cargo tree -i rocksdb` presence and absence assertions, so a change that reintroduces the native dependency through this crate fails there. The Features paragraph in `AGENTS.md` names the crate among the forwarders.
Follows the review on #834, which rebases onto this once it lands, alongside #847.
## How are the changes test-covered
- [ ] N/A
- [x] Automated tests (unit and/or integration tests)
- [x] Manual tests
- [x] Details are described below
The CI dependency-graph assertion is the test: with `--no-default-features`, `cargo tree -p hudi-jvm-ffi -i rocksdb` reports the package absent, and with defaults it still lists `rocksdb` under `hudi-core`. On `main` the opt-out form still reaches `rocksdb`. Locally, `cargo check`, `cargo clippy --all-targets -D warnings` and `cargo test -p hudi-jvm-ffi` pass both with defaults and with `--no-default-features`, and `Cargo.lock` is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(ffi): forward the spill-rocksdb feature through hudi-jvm-ffi [hudi-rs]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #849:
URL: https://github.com/apache/hudi-rs/pull/849#issuecomment-6454763995
## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/849?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.76%. Comparing base ([`cc5365b`](https://app.codecov.io/gh/apache/hudi-rs/commit/cc5365b59a4fc84051718fbb40abe2dd444ce0ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1d24c83`](https://app.codecov.io/gh/apache/hudi-rs/commit/1d24c8360f829c018950bda6be2977f32ca638ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 79.76% 79.76%
=======================================
Files 128 128
Lines 12577 12577
=======================================
Hits 10032 10032
Misses 2545 2545
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hudi-rs/pull/849?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(ffi): forward the spill-rocksdb feature through hudi-ffi [hudi-rs]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #849:
URL: https://github.com/apache/hudi-rs/pull/849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org