[jira] [Commented] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

["Fabian Hueske (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051610#comment-16051610 ] 

Fabian Hueske commented on FLINK-6887:
--------------------------------------

I think that's a good idea. What do you think [~twalthr]?

> Split up CodeGenerator into several specific CodeGenerator
> ----------------------------------------------------------
>
>                 Key: FLINK-6887
>                 URL: https://issues.apache.org/jira/browse/FLINK-6887
>             Project: Flink
>          Issue Type: Task
>          Components: Table API & SQL
>            Reporter: Jark Wu
>             Fix For: 1.4.0
>
>
> Currently, the {{CodeGenerator}} is very huge and a bit difficult to maintain. I suggest to split it up into several specific {{XXXCodeGenerator}}.
> For example, create {{AggregationFunctionCodeGenerator}}  class and make it extend to {{CodeGenerator}} and move the {{def generateAggregations(...)}} method to it. The same as {{TableFunctionCollectorCodeGenerator}} and {{InputFormatCodeGenerator}}.
> What do you think? [~fhueske], [~twalthr], [~sunjincheng121]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)