You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "KatalKavya96 (via GitHub)" <gi...@apache.org> on 2026/10/20 06:46:38 UTC
[PR] feat(bitbucket): add Data Center pull request comments [magpie]
KatalKavya96 opened a new pull request, #1728:
URL: https://github.com/apache/magpie/pull/1728
## Summary
- Add Bitbucket Data Center support for creating top-level pull-request comments.
- Reuse the existing `pr comment <id> --body-file <path>` command across Cloud and Data Center.
- Normalize created Data Center comments into the existing backend-neutral comment shape.
- Add backend, normalizer, and CLI coverage for the Data Center write path.
- Update Bitbucket capability documentation to reflect Cloud + Data Center comment support.
## Type of change
- [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
- [x] Tool / bridge contract (`tools/<system>/*.md`)
- [x] Python package (`tools/*/` with `pyproject.toml`)
- [ ] Groovy reference impl
- [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
- [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
- [ ] Project template (`projects/_template/`)
- [ ] CI / dev loop (`prek`, workflows, validators)
- [ ] Other
## Test plan
- [x] `uv run --group dev ruff check src tests --fix`
- [x] `uv run --group dev ruff format src tests`
- [x] `uv run --group dev mypy src tests`
- [x] Focused PR-comment tests pass
- [x] Full `tools/bitbucket/tests/test_bitbucket.py` suite passes
- [x] `git diff --check` passes
## Implementation
Bitbucket Data Center now creates a pull-request comment with:
`POST /rest/api/1.0/projects/{project}/repos/{repo}/pull-requests/{id}/comments`
using the Data Center payload:
`{"text": "<comment body>"}`
The returned Data Center comment is normalized through the existing pull-request comment output contract so callers continue using the same CLI and normalized response shape regardless of backend.
Write-path discipline is unchanged: the bridge executes the mutation only after the calling skill has obtained explicit user confirmation.
## Scope
This PR only adds **Data Center top-level pull-request comment creation**.
Data Center approval/change-request, review verdict, decline/reject, and merge writes remain separate follow-up work under #606.
Refs #606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitbucket): add Data Center pull request comments [magpie]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #1728:
URL: https://github.com/apache/magpie/pull/1728#issuecomment-6285132418
Hi @potiuk,
This is the next focused #606 follow-up for Bitbucket Data Center parity.
It adds Data Center support for the existing `pr comment <id> --body-file` command using the documented pull-request comments endpoint and keeps the same normalized output shape as Cloud.
Coverage added for:
- the Data Center POST request and payload
- created-comment normalization
- CLI dispatch/output
- existing empty/missing body fail-closed behavior
The full Bitbucket test suite, ruff, formatting, mypy, `git diff --check`, and repo hooks pass.
Data Center review/approval, decline/reject, and merge writes remain separate follow-ups.
Refs #606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitbucket): add Data Center pull request comments [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1728:
URL: https://github.com/apache/magpie/pull/1728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org