You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2024/08/31 19:54:13 UTC
[PR] New Feature: Multi-arch Zones [cloudstack]
nvazquez opened a new pull request, #9619:
URL: https://github.com/apache/cloudstack/pull/9619
### Description
This PR introduces the multi-arch zones, allowing users to select the VM arch upon deployment.
Multi-arch zone support in CloudStack can allow admins to mix x86_64 & arm64 hosts within the same zone with the following changes proposed:
- All hosts in a clusters need to be homogenous, wrt host CPU type (amd64 vs arm64) and hypevisor
- Arch-aware templates & ISOs:
- Add support for a new arch field (default set of: amd64 and arm64), when unspecified defaults to amd64 and for existing templates & iso
- Allow admins to edit the arch type of the registered template & iso
- Arch-aware clusters and host:
- Add new attribute field for cluster and hosts (kvm host agents can automatically report this, arch of the first host of the cluster is cluster's architecture), defaults to amd64 when not specified
- Allow admins to edit the arch of an existing cluster
- VM deployment form (UI):
- In a multi-arch zone/env, the VM deployment form can allow some kind of template/iso filtration in the UI
- Users should be able to select arch: amd64 & arm64; but this is shown only in a multi-arch zone (env)
- VM orchestration and lifecycle operations:
- Use of VM/template's arch to correctly decide where to provision the VM (on the correct strictly arch-matching host/clusters) & other lifecycle operations (such as migration from/to arch-matching hosts)
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
<img width="936" alt="Screenshot 2024-08-31 at 16 52 57" src="https://github.com/user-attachments/assets/08db84ae-ead5-4fa9-a60b-a48b111fa89b">
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740534538
##########
api/src/main/java/org/apache/cloudstack/api/response/ClusterResponse.java:
##########
@@ -247,4 +251,12 @@ public void setOvm3vip(String ovm3vip) {
public void setCapacities(List<CapacityResponse> capacities) {
this.capacities = capacities;
}
+
+ public String getArchitecture() {
+ return architecture;
+ }
+
Review Comment:
is this one needed?
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -1213,6 +1215,11 @@ public Cluster updateCluster(UpdateClusterCmd cmd) {
}
}
+ if (architecture != null) {
Review Comment:
meaning it can never be unset?
##########
api/src/main/java/org/apache/cloudstack/api/response/HostResponse.java:
##########
@@ -787,6 +791,14 @@ public void setIsTagARule(Boolean tagARule) {
isTagARule = tagARule;
}
+ public String getArchitecture() {
+ return architecture;
+ }
+
Review Comment:
is this one needed?
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -2746,6 +2753,13 @@ public HostVO fillRoutingHostVO(final HostVO host, final StartupRoutingCommand s
throw new IllegalArgumentException("Can't add host whose hypervisor type is: " + hyType + " into cluster: " + clusterVO.getId() +
" whose hypervisor type is: " + clusterVO.getHypervisorType());
}
+ CPU.CPUArchitecture hostCpuArchitecture = CPU.CPUArchitecture.fromType(ssCmd.getCpuArchitecture());
+ if (hostCpuArchitecture != null && clusterVO.getArch() != null && hostCpuArchitecture != clusterVO.getArch()) {
+ String msg = String.format("Can't add a host whose architecture is: %s into cluster of architecture type: %s",
+ hostCpuArchitecture.getType(), clusterVO.getArch().getType());
+ logger.error(msg);
+ throw new IllegalArgumentException(msg);
+ }
Review Comment:
this bit makes the isMultiArch flag necessary. I think we shouldn't implement that and allow dynamic use of architectures (responsibility of the operator) cc @rajujith @andrijapanicsb @NuxRo
##########
api/src/main/java/com/cloud/cpu/CPU.java:
##########
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.cpu;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.lang3.StringUtils;
+
+public class CPU {
+
+ public static final String archX86Identifier = "i686";
+ public static final String archX86_64Identifier = "x86_64";
+ public static final String archARM64Identifier = "arm64";
+
+ public enum CPUArchitecture {
Review Comment:
why is this enum embedded in a class and not top levwel in the package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740729425
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -2746,6 +2753,13 @@ public HostVO fillRoutingHostVO(final HostVO host, final StartupRoutingCommand s
throw new IllegalArgumentException("Can't add host whose hypervisor type is: " + hyType + " into cluster: " + clusterVO.getId() +
" whose hypervisor type is: " + clusterVO.getHypervisorType());
}
+ CPU.CPUArchitecture hostCpuArchitecture = CPU.CPUArchitecture.fromType(ssCmd.getCpuArchitecture());
+ if (hostCpuArchitecture != null && clusterVO.getArch() != null && hostCpuArchitecture != clusterVO.getArch()) {
+ String msg = String.format("Can't add a host whose architecture is: %s into cluster of architecture type: %s",
+ hostCpuArchitecture.getType(), clusterVO.getArch().getType());
+ logger.error(msg);
+ throw new IllegalArgumentException(msg);
+ }
Review Comment:
So what if all hosts/clusters for a certain arch are removed, will it fall back to single arch? (i.e. what is the use of the flag)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331997011
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331371429
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332211965
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332387948
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331333135
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2328730840
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745903194
##########
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##########
@@ -234,6 +234,11 @@ CALL `cloud`.`IDEMPOTENT_MODIFY_COLUMN_CHAR_SET`('vpc_offerings', 'display_text'
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.roles','state', 'varchar(10) NOT NULL default "enabled" COMMENT "role state"');
+-- Multi-Arch Zones
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.cluster', 'arch', 'varchar(8) DEFAULT "x86_64" COMMENT "the CPU architecture of the hosts in the cluster"');
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.host', 'arch', 'varchar(8) DEFAULT "x86_64" COMMENT "the CPU architecture of the host"');
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_template', 'arch', 'varchar(8) DEFAULT "x86_64" COMMENT "the CPU architecture of the template/ISO"');
+
Review Comment:
we assume that all arch are of type x86_64, which can be changed if that's not the case ; as majority of the prod. deployment will anyway be x86_64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323056659
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745998669
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java:
##########
@@ -204,6 +210,10 @@ public ApiCommandResourceType getApiResourceType() {
return ApiCommandResourceType.Cluster;
}
+ public CPU.CPUArch getArch() {
+ return CPU.CPUArch.fromType(arch);
Review Comment:
The same applies for the other getArch() getters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332250113
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745338561
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/GetUploadParamsForTemplateCmd.java:
##########
@@ -162,6 +168,10 @@ public boolean isDeployAsIs() {
Boolean.TRUE.equals(deployAsIs);
}
+ public CPU.CPUArch getArch() {
+ return CPU.CPUArch.fromType(arch);
Review Comment:
```suggestion
if (StringUtils.isBlank(arch)) {
return null;
}
return CPU.CPUArch.fromType(arch);
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2328533737
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323056458
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740529149
##########
api/src/main/java/com/cloud/cpu/CPU.java:
##########
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.cpu;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.lang3.StringUtils;
+
+public class CPU {
+
+ public static final String archX86Identifier = "i686";
+ public static final String archX86_64Identifier = "x86_64";
+ public static final String archARM64Identifier = "arm64";
+
+ public enum CPUArchitecture {
Review Comment:
why is this enum embedded in a class and not top level in the package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323030477
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1741449861
##########
api/src/main/java/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java:
##########
@@ -88,6 +90,11 @@ public class ListIsosCmd extends BaseListTaggedResourcesCmd implements UserCmd {
@Parameter(name = ApiConstants.SHOW_RESOURCE_ICON, type = CommandType.BOOLEAN, description = "flag to display the resource image for the isos")
private Boolean showIcon;
+ @Parameter(name = ApiConstants.ARCHITECTURE, type = CommandType.STRING,
+ description = "the CPU architecture of the ISO. Valid options are: x86_64, arm64",
Review Comment:
same comments as for templates. Btw on second though, this is fine too as long as we stick to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323060355
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9619 (QA-JID-436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332371092
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323030320
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2327930235
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2330628052
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331172735
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331672610
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1742757198
##########
api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java:
##########
@@ -77,6 +79,11 @@ public abstract class BaseUpdateTemplateOrIsoCmd extends BaseCmd {
description = "optional boolean field, which indicates if details should be cleaned up or not (if set to true, details removed for this resource, details field ignored; if false or not set, no action)")
private Boolean cleanupDetails;
+ @Parameter(name = ApiConstants.ARCHITECTURE, type = CommandType.STRING,
Review Comment:
Thanks @rohityadavcloud - I think its better to stick with the /usr/bin/arch return values as dpkg is only available on debian based OS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2327931443
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2330670867
<b>[SF] Trillian test result (tid-11346)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53001 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9619-t11346-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_unsecure_vm_migration | `Error` | 447.72 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 448.07 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745997891
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java:
##########
@@ -204,6 +210,10 @@ public ApiCommandResourceType getApiResourceType() {
return ApiCommandResourceType.Cluster;
}
+ public CPU.CPUArch getArch() {
+ return CPU.CPUArch.fromType(arch);
Review Comment:
Hi @sureshanaparti it will fallback to the default arch (x86_64) as in DB we won't have null values for clusters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2333260551
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2333801119
<b>[SF] Trillian test result (tid-11386)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55615 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9619-t11386-kvm-ol8.zip
Smoke tests completed. 137 look OK, 1 have errors, 2 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_mount_shared_fs | `Failure` | 93.24 | test_sharedfs_lifecycle.py
test_resize_shared_fs | `Error` | 0.23 | test_sharedfs_lifecycle.py
all_test_network | `Skipped` | --- | test_network.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1741447895
##########
api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java:
##########
@@ -77,6 +79,11 @@ public abstract class BaseUpdateTemplateOrIsoCmd extends BaseCmd {
description = "optional boolean field, which indicates if details should be cleaned up or not (if set to true, details removed for this resource, details field ignored; if false or not set, no action)")
private Boolean cleanupDetails;
+ @Parameter(name = ApiConstants.ARCHITECTURE, type = CommandType.STRING,
Review Comment:
Should this be amd64 & arm64? Or, name them as: `x86_64 and aarch64`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740723217
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -1213,6 +1215,11 @@ public Cluster updateCluster(UpdateClusterCmd cmd) {
}
}
+ if (architecture != null) {
Review Comment:
It cannot be unset but can be changed. Please note from the upgrade schema, every existing cluster pre-upgrade will have a set default value (there will be no unset arch values)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1741447253
##########
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##########
@@ -33,6 +33,7 @@ public class ApiConstants {
public static final String ANNOTATION = "annotation";
public static final String API_KEY = "apikey";
public static final String ARCHIVED = "archived";
+ public static final String ARCHITECTURE = "architecture";
Review Comment:
shortened `arch` is acceptable term, `/usr/bin/arch` returns the linux distro arch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2328537647
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2327943620
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1743132012
##########
agent/src/main/java/com/cloud/agent/Agent.java:
##########
@@ -504,6 +504,13 @@ protected void setupStartupCommand(final StartupCommand startup) {
startup.setGuid(getResourceGuid());
startup.setResourceName(getResourceName());
startup.setVersion(getVersion());
+ startup.setArch(getAgentArch());
+ }
+
+ protected String getAgentArch() {
+ final Script command = new Script("/usr/bin/arch", 500, logger);
Review Comment:
Thanks, this LGTM, but on second though the virsh node info returns the arch - perhaps instead of forking out a shell process - we can simply query via libvirt connection?
```
> virsh nodeinfo
CPU model: x86_64
...
# on rpi5:
rohit@cloudpi:~$ virsh nodeinfo
CPU model: aarch64
CPU(s): 4
CPU socket(s): 1
Core(s) per socket: 4
Thread(s) per core: 1
NUMA cell(s): 1
Memory size: 8132920 KiB
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331224990
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745346225
##########
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##########
@@ -234,6 +234,11 @@ CALL `cloud`.`IDEMPOTENT_MODIFY_COLUMN_CHAR_SET`('vpc_offerings', 'display_text'
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.roles','state', 'varchar(10) NOT NULL default "enabled" COMMENT "role state"');
+-- Multi-Arch Zones
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.cluster', 'arch', 'varchar(8) DEFAULT "x86_64" COMMENT "the CPU architecture of the hosts in the cluster"');
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.host', 'arch', 'varchar(8) DEFAULT "x86_64" COMMENT "the CPU architecture of the host"');
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_template', 'arch', 'varchar(8) DEFAULT "x86_64" COMMENT "the CPU architecture of the template/ISO"');
+
Review Comment:
@nvazquez Is arch updated for the existing hosts, templates with the appropriate arch if other than x86_64?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331099139
@nvazquez can you check/fix the lint issue & kick packaging. After that this should mergeable, pending no other issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323112096
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740720866
##########
api/src/main/java/org/apache/cloudstack/api/response/HostResponse.java:
##########
@@ -787,6 +791,14 @@ public void setIsTagARule(Boolean tagARule) {
isTagARule = tagARule;
}
+ public String getArchitecture() {
+ return architecture;
+ }
+
Review Comment:
Thanks, the getter is not used, will remove it
##########
api/src/main/java/org/apache/cloudstack/api/response/ClusterResponse.java:
##########
@@ -247,4 +251,12 @@ public void setOvm3vip(String ovm3vip) {
public void setCapacities(List<CapacityResponse> capacities) {
this.capacities = capacities;
}
+
+ public String getArchitecture() {
+ return architecture;
+ }
+
Review Comment:
Thanks, the getter is not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745336117
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java:
##########
@@ -204,6 +210,10 @@ public ApiCommandResourceType getApiResourceType() {
return ApiCommandResourceType.Cluster;
}
+ public CPU.CPUArch getArch() {
+ return CPU.CPUArch.fromType(arch);
Review Comment:
check if this is Ok for null arch (as it is optional)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2330573765
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331221894
Thanks @rohityadavcloud - fixed
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2327988167
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2331676885
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2333345155
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332386134
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745338561
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/GetUploadParamsForTemplateCmd.java:
##########
@@ -162,6 +168,10 @@ public boolean isDeployAsIs() {
Boolean.TRUE.equals(deployAsIs);
}
+ public CPU.CPUArch getArch() {
+ return CPU.CPUArch.fromType(arch);
Review Comment:
```suggestion
if (StringUtils.isBlank(arch)) {
return null;
}
return CPU.CPUArch.fromType(arch);
```
check the same in other _getArch()_ methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332249001
cc @nvazquez hope I haven't screwed up 🤞 the merge conflict
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323042614
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740947929
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -2746,6 +2753,13 @@ public HostVO fillRoutingHostVO(final HostVO host, final StartupRoutingCommand s
throw new IllegalArgumentException("Can't add host whose hypervisor type is: " + hyType + " into cluster: " + clusterVO.getId() +
" whose hypervisor type is: " + clusterVO.getHypervisorType());
}
+ CPU.CPUArchitecture hostCpuArchitecture = CPU.CPUArchitecture.fromType(ssCmd.getCpuArchitecture());
+ if (hostCpuArchitecture != null && clusterVO.getArch() != null && hostCpuArchitecture != clusterVO.getArch()) {
+ String msg = String.format("Can't add a host whose architecture is: %s into cluster of architecture type: %s",
+ hostCpuArchitecture.getType(), clusterVO.getArch().getType());
+ logger.error(msg);
+ throw new IllegalArgumentException(msg);
+ }
Review Comment:
again, why is that not always available? I still don't see the need for the flag. a zone has hosts and hosts can only be grouped with hosts of the same arch in a cluster, but there is no reason to assume a zone is of only one arch at any time, is there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740882579
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -2746,6 +2753,13 @@ public HostVO fillRoutingHostVO(final HostVO host, final StartupRoutingCommand s
throw new IllegalArgumentException("Can't add host whose hypervisor type is: " + hyType + " into cluster: " + clusterVO.getId() +
" whose hypervisor type is: " + clusterVO.getHypervisorType());
}
+ CPU.CPUArchitecture hostCpuArchitecture = CPU.CPUArchitecture.fromType(ssCmd.getCpuArchitecture());
+ if (hostCpuArchitecture != null && clusterVO.getArch() != null && hostCpuArchitecture != clusterVO.getArch()) {
+ String msg = String.format("Can't add a host whose architecture is: %s into cluster of architecture type: %s",
+ hostCpuArchitecture.getType(), clusterVO.getArch().getType());
+ logger.error(msg);
+ throw new IllegalArgumentException(msg);
+ }
Review Comment:
The flag is used for the UI to display the different archs available so users can filter templates by arch on the VM deployment wizard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1741449230
##########
api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java:
##########
@@ -77,6 +79,11 @@ public abstract class BaseUpdateTemplateOrIsoCmd extends BaseCmd {
description = "optional boolean field, which indicates if details should be cleaned up or not (if set to true, details removed for this resource, details field ignored; if false or not set, no action)")
private Boolean cleanupDetails;
+ @Parameter(name = ApiConstants.ARCHITECTURE, type = CommandType.STRING,
Review Comment:
See outputs of /usr/bin/arch & ` dpkg --print-architecture`.
On x86 machine, arch returns 'x86_64' but dpkg returns 'amd64'.
On rpi5/arm machine, arch returns `aarch64` but dpkg returns `arm64`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1741449453
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java:
##########
@@ -53,6 +55,11 @@ public class UpdateClusterCmd extends BaseCmd {
@Parameter(name = ApiConstants.MANAGED_STATE, type = CommandType.STRING, description = "whether this cluster is managed by cloudstack")
private String managedState;
+ @Parameter(name = ApiConstants.ARCHITECTURE, type = CommandType.STRING,
+ description = "the CPU architecture of the template/ISO. Valid options are: x86_64, arm64",
Review Comment:
Description wrong, should relate to arch of the cluster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2327985283
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2328718168
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323112219
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332244870
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1743134929
##########
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java:
##########
@@ -455,6 +460,22 @@ public DeployDestination planDeployment(VirtualMachineProfile vmProfile, Deploym
return dest;
}
+ private void avoidDifferentArchResources(VirtualMachineProfile vmProfile, DataCenter dc, ExcludeList avoids) {
Review Comment:
minor - suggested unit test could be great, otherwise great addition!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2330570091
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2330572377
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2328728735
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2328434290
@nvazquez can you merge latest main and address conflicts? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740726168
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -2746,6 +2753,13 @@ public HostVO fillRoutingHostVO(final HostVO host, final StartupRoutingCommand s
throw new IllegalArgumentException("Can't add host whose hypervisor type is: " + hyType + " into cluster: " + clusterVO.getId() +
" whose hypervisor type is: " + clusterVO.getHypervisorType());
}
+ CPU.CPUArchitecture hostCpuArchitecture = CPU.CPUArchitecture.fromType(ssCmd.getCpuArchitecture());
+ if (hostCpuArchitecture != null && clusterVO.getArch() != null && hostCpuArchitecture != clusterVO.getArch()) {
+ String msg = String.format("Can't add a host whose architecture is: %s into cluster of architecture type: %s",
+ hostCpuArchitecture.getType(), clusterVO.getArch().getType());
+ logger.error(msg);
+ throw new IllegalArgumentException(msg);
+ }
Review Comment:
The multiArch flag is a dynamic check, whenever you add a different arch cluster in your existing zone, then the multiArch flag becomes true and allows the operator to select the template arch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1741450676
##########
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##########
@@ -233,3 +233,8 @@ CALL `cloud`.`IDEMPOTENT_MODIFY_COLUMN_CHAR_SET`('vpc_offerings', 'unique_name',
CALL `cloud`.`IDEMPOTENT_MODIFY_COLUMN_CHAR_SET`('vpc_offerings', 'display_text', 'VARCHAR(255)', 'DEFAULT NULL COMMENT \'display text\'');
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.roles','state', 'varchar(10) NOT NULL default "enabled" COMMENT "role state"');
+
+-- Multi-Arch Zones
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.cluster', 'arch', 'varchar(8) DEFAULT "x86_64" COMMENT "the CPU architecture of the hosts in the cluster"');
Review Comment:
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2330568392
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1745337399
##########
api/src/main/java/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java:
##########
@@ -229,6 +235,14 @@ public boolean isPasswordEnabled() {
return passwordEnabled == null ? false : passwordEnabled;
}
+ public void setArch(String arch) {
+ this.arch = arch;
+ }
+
+ public CPU.CPUArch getArch() {
+ return CPU.CPUArch.fromType(arch);
Review Comment:
```suggestion
if (StringUtils.isBlank(arch)) {
return null;
}
return CPU.CPUArch.fromType(arch);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2328018801
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323413217
<b>[SF] Trillian test result (tid-11274)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9619-t11274-kvm-ol8.zip
Smoke tests completed. 139 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2323031713
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9619?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.16%. Comparing base [(`5a496e7`)](https://app.codecov.io/gh/apache/cloudstack/commit/5a496e725b937571e4534b64a2898f65dbb9df3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d70a977`)](https://app.codecov.io/gh/apache/cloudstack/commit/d70a97716fb1c3fdf2dd7d647b071b8d867d7bf7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 7 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (5a496e7) and HEAD (d70a977). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (5a496e7) | HEAD (d70a977) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9619 +/- ##
============================================
- Coverage 15.58% 4.16% -11.42%
============================================
Files 5504 377 -5127
Lines 482386 30924 -451462
Branches 62084 5470 -56614
============================================
- Hits 75156 1288 -73868
+ Misses 398927 29490 -369437
+ Partials 8303 146 -8157
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9619/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9619/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.16% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9619/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9619?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#discussion_r1740718728
##########
api/src/main/java/com/cloud/cpu/CPU.java:
##########
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.cpu;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.lang3.StringUtils;
+
+public class CPU {
+
+ public static final String archX86Identifier = "i686";
+ public static final String archX86_64Identifier = "x86_64";
+ public static final String archARM64Identifier = "arm64";
+
+ public enum CPUArchitecture {
Review Comment:
It can, but I thought it made sense including it as part of the CPU class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2325640037
@nvazquez do we also need changes to deployment planner (orchestration), so VM deployment plan/planning considers arch of the iso/template against that of the cluster & hosts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332209255
Minor conflict (no need for repackaging though), pl address @nvazquez
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2332259055
<b>[SF] Trillian Build Failed (tid-11382)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] New Feature: Multi-arch Zones [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9619:
URL: https://github.com/apache/cloudstack/pull/9619#issuecomment-2333258912
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org