You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/15 19:14:04 UTC
[GitHub] [iceberg-docs] amogh-jahagirdar opened a new pull request #55: Docs: Update documentation for 0.13.1 release
amogh-jahagirdar opened a new pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55
In this change we are copying over the new markdowns and doc changes from the Iceberg repo. Validated by running hugo serve for the landing page/docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] amogh-jahagirdar commented on pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#issuecomment-1040935777
> @amogh-jahagirdar sorry there are a few changes that are being introduced but are actually reversions. This is because right as the new site was released there were a number of changes that were being introduced in both places and weren't synced. I think this should all stable out over time but for now I think you can just remove the changes to those lines in this PR (I think I've tagged all of them expect the `spec/*` ones which are sprinkled on that page.
No problem! I will remove all the relevant changes. After this is merged, we can copy back to iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#issuecomment-1040921523
@amogh-jahagirdar sorry there are a few changes that are being introduced but are actually reversions. This is because right as the new site was released there were a number of changes that were being introduced in both places and weren't synced. I think this should all stable out over time but for not I think you can just remove the changes to those lines in this PR (I think I've tagged all of them expect the `spec/*` ones which are sprinkled on that page.
@jackye1995 I think once this is merged, I can do one more full copy from here to `apache/iceberg` and we should be ready to tighten up the contribution rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807416183
##########
File path: docs/content/docs/spark/spark-procedures.md
##########
@@ -275,9 +275,9 @@ Iceberg can compact data files in parallel using Spark with the `rewriteDataFile
| `where` | ️ | string | predicate as a string used for filtering the files. Note that all files that may contain data matching the filter will be selected for rewriting|
-See the [`RewriteDataFiles` Javadoc](../../../javadoc/{{% icebergVersion %}}/org/apache/iceberg/actions/RewriteDataFiles.html#field.summary),
-<br/> [`BinPackStrategy` Javadoc](../../../javadoc/{{% icebergVersion %}}/org/apache/iceberg/actions/BinPackStrategy.html#field.summary)
-and <br/> [`SortStrategy` Javadoc](../../../javadoc/{{% icebergVersion %}}/org/apache/iceberg/actions/SortStrategy.html#field.summary)
+See the [`RewriteDataFiles` Javadoc](./javadoc/{{ versions.iceberg }}/org/apache/iceberg/actions/RewriteDataFiles.html#field.summary),
Review comment:
Here as well, the `../../../javadoc/*` are the correct links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807413519
##########
File path: landing-page/layouts/partials/header.html
##########
@@ -39,6 +39,9 @@
<li>
<a class="page-scroll" href="{{ .Site.BaseURL }}community">Community</a>
</li>
+ <li>
+ <a class="page-scroll" href="{{ .Site.BaseURL }}contribute">Contribute</a>
Review comment:
I know some people have suggested drop-downs, which I think could work but I personally like the simplicity of just having the items there. I don't think we need to have top level links to every page. What if `/contribute` is only reachable by a link included in `community.md` and also a link in the iceberg repo's readme?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai edited a comment on pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai edited a comment on pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#issuecomment-1040921523
@amogh-jahagirdar sorry there are a few changes that are being introduced but are actually reversions. This is because right as the new site was released there were a number of changes that were being introduced in both places and weren't synced. I think this should all stable out over time but for now I think you can just remove the changes to those lines in this PR (I think I've tagged all of them expect the `spec/*` ones which are sprinkled on that page.
@jackye1995 I think once this is merged, I can do one more full copy from here to `apache/iceberg` and we should be ready to tighten up the contribution rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] amogh-jahagirdar edited a comment on pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar edited a comment on pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#issuecomment-1040935777
> @amogh-jahagirdar sorry there are a few changes that are being introduced but are actually reversions. This is because right as the new site was released there were a number of changes that were being introduced in both places and weren't synced. I think this should all stable out over time but for now I think you can just remove the changes to those lines in this PR (I think I've tagged all of them expect the `spec/*` ones which are sprinkled on that page.
@samredai No problem! I will remove all the relevant changes. After this is merged, we can copy back to iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807430073
##########
File path: docs/content/docs/integrations/aws.md
##########
@@ -480,7 +480,7 @@ AWS_PACKAGES=(
)
ICEBERG_PACKAGES=(
- "iceberg-spark-runtime-3.2_2.12"
+ "iceberg-spark3-runtime"
Review comment:
yes agree, let's do manual resolutions for these for 0.13.1, and let me start a thread for doc change contribution pattern in the dev list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807416835
##########
File path: landing-page/content/common/format/spec.md
##########
@@ -34,15 +34,15 @@ The format version number is incremented when new features are added that will b
Version 1 of the Iceberg spec defines how to manage large analytic tables using immutable file formats: Parquet, Avro, and ORC.
-All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](spec/#version-2) documents how to default version 2 fields when reading version 1 metadata.
+All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](#version-2) documents how to default version 2 fields when reading version 1 metadata.
Review comment:
This should be kept as well, `spec/#version-2` is the correct link. There are a few other places where `spec/` is being removed but should be kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#issuecomment-1041009684
merging this to continue with the release process, we can add patch in case anything is wrong, thanks for the review @samredai and thanks for the work @amogh-jahagirdar!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807416835
##########
File path: landing-page/content/common/format/spec.md
##########
@@ -34,15 +34,15 @@ The format version number is incremented when new features are added that will b
Version 1 of the Iceberg spec defines how to manage large analytic tables using immutable file formats: Parquet, Avro, and ORC.
-All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](spec/#version-2) documents how to default version 2 fields when reading version 1 metadata.
+All version 1 data and metadata files are valid after upgrading a table to version 2. [Appendix E](#version-2) documents how to default version 2 fields when reading version 1 metadata.
Review comment:
This should be kept as well, `spec/#version-2` is the correct link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807417568
##########
File path: landing-page/content/common/format/spec.md
##########
@@ -839,7 +839,7 @@ Note that the string map case is for maps where the key type is a string. Using
Values should be stored in Parquet using the types and logical type annotations in the table below. Column IDs are required.
-Lists must use the [3-level representation](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists).
+Lists must use the [3-level representation](https://github.com/apache/parquet-format/blob/master/LogicalTypes#lists).
Review comment:
The original link here should be kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807430445
##########
File path: landing-page/layouts/partials/header.html
##########
@@ -39,6 +39,9 @@
<li>
<a class="page-scroll" href="{{ .Site.BaseURL }}community">Community</a>
</li>
+ <li>
+ <a class="page-scroll" href="{{ .Site.BaseURL }}contribute">Contribute</a>
Review comment:
have a link in community page also works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807345935
##########
File path: landing-page/layouts/partials/header.html
##########
@@ -39,6 +39,9 @@
<li>
<a class="page-scroll" href="{{ .Site.BaseURL }}community">Community</a>
</li>
+ <li>
+ <a class="page-scroll" href="{{ .Site.BaseURL }}contribute">Contribute</a>
Review comment:
I think it's worth adding a contribute tab, but how many tabs can we add in header? I hope we don't keep adding new tabs and cause issue in UI. @samredai any guideline here we should follow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a change in pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#discussion_r807415762
##########
File path: docs/content/docs/integrations/aws.md
##########
@@ -480,7 +480,7 @@ AWS_PACKAGES=(
)
ICEBERG_PACKAGES=(
- "iceberg-spark-runtime-3.2_2.12"
+ "iceberg-spark3-runtime"
Review comment:
Looks like these changes were made here but not synced back in `apache/iceberg`. @jackye1995 should we do one more manual resolution and try to get a consensus on a contributing pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 merged pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] amogh-jahagirdar commented on pull request #55: Docs: Update documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on pull request #55:
URL: https://github.com/apache/iceberg-docs/pull/55#issuecomment-1040992893
Updated, removed the relevant changes with the bad links (I think we can sync back to iceberg after this gets merged as @samredai mentioned). I also made a contributing section in "Join" which links to the new contributing page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org