You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Shuozeli (via GitHub)" <gi...@apache.org> on 2023/05/21 23:02:02 UTC
[GitHub] [rocketmq-streams] Shuozeli opened a new pull request, #295: Filter the removeQueues from addQueues when recovering the state
Shuozeli opened a new pull request, #295:
URL: https://github.com/apache/rocketmq-streams/pull/295
Closes #281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze merged pull request #295: [ISSUE #281] Do not process the data from the removed MessageQueues by removing the queues from the originListener first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze merged PR #295:
URL: https://github.com/apache/rocketmq-streams/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #295: [ISSUE #281] Do not process the data from the removed MessageQueues by removing the queues from the originListener first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #295:
URL: https://github.com/apache/rocketmq-streams/pull/295#issuecomment-1597998488
没啥问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Shuozeli commented on pull request #295: [ISSUE #281] Do not process the data from the removed MessageQueues by removing the queues from the originListener first
Posted by "Shuozeli (via GitHub)" <gi...@apache.org>.
Shuozeli commented on PR #295:
URL: https://github.com/apache/rocketmq-streams/pull/295#issuecomment-1595848248
能请你review下代码吗，看看这个代码还有没有别的问题，谢谢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Shuozeli commented on pull request #295: [ISSUE #281]Filter the removeQueues from addQueues when recovering the state
Posted by "Shuozeli (via GitHub)" <gi...@apache.org>.
Shuozeli commented on PR #295:
URL: https://github.com/apache/rocketmq-streams/pull/295#issuecomment-1586409055
@ni-ze 抱歉，我之前的理解有些错误。我改了一下code：
第一步：将需要被删除的 `removeQueue` 从 `originalListener` 删掉。做法是调用 `originListener.messageQueueChanged`，但传入的是 `unchangedQueue` 的set，这样 `originalListener` 会停止接收 `removedQueue` 的消息。
第二步：对状态进行操作。
第三步：把 `addQueue` 加入到 `originalListener` 里边。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Shuozeli commented on pull request #295: Filter the removeQueues from addQueues when recovering the state
Posted by "Shuozeli (via GitHub)" <gi...@apache.org>.
Shuozeli commented on PR #295:
URL: https://github.com/apache/rocketmq-streams/pull/295#issuecomment-1556324370
因为 `removeState` 中的所有操作都支持删除一个不存在的 key，所以当 `loadState` 时不去加载应该被删除的 queue，不会影响 `removeState`。如果不加在应该被删除的 queue，也不会存在介于 `loadState` 和 `removeState` 之间的 inflight data
如果我的理解有错误，请指正，谢谢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #295: [ISSUE #281] Do not process the data from the removed MessageQueues by removing the queues from the originListener first
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #295:
URL: https://github.com/apache/rocketmq-streams/pull/295#issuecomment-1593942884
LGTM～
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #295: [ISSUE #281]Filter the removeQueues from addQueues when recovering the state
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #295:
URL: https://github.com/apache/rocketmq-streams/pull/295#issuecomment-1585626577
@Shuozeli我又重新看了下，产生这个问题的根源貌似是这样：
this.recoverHandler.apply(addQueue, removeQueue)
将状态从本地移除，但是这时候还没有出发rebalance，会继续从将要被移除的queue里面拉数据。这时候就有问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org