[GitHub] [kafka] cmccabe commented on a diff in pull request #13890: KAFKA-15109 Don't skip leader epoch bump while in migration mode

["cmccabe (via GitHub)" <gi...@apache.org>]

cmccabe commented on code in PR #13890:
URL: https://github.com/apache/kafka/pull/13890#discussion_r1235713408


##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -87,13 +89,16 @@ public PartitionChangeBuilder(
         Uuid topicId,
         int partitionId,
         IntPredicate isAcceptableLeader,
-        MetadataVersion metadataVersion
+        MetadataVersion metadataVersion,
+        boolean zkMigrationEnabled

Review Comment:
   I think this should be descriptive, like "bumpLeaderEpochOnIsrShrink". Then it can be initialized to `!metadataVersion.isSkipLeaderEpochBumpSupported()`. Then we can have a setter function that overrides it, and we can do
   ```
   if (zkMigrationEnabled) {
     builder.setBumpLeaderEpochOnIsrShrink(true);
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org