You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/28 05:15:54 UTC

[GitHub] [pulsar] AnonHxy commented on a change in pull request #14890: [feat][broker]Dynamic update broker-level subscribe-rate limter

AnonHxy commented on a change in pull request #14890:
URL: https://github.com/apache/pulsar/pull/14890#discussion_r836059721



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -185,7 +185,6 @@
     public boolean msgChunkPublished;
 
     private Optional<DispatchRateLimiter> dispatchRateLimiter = Optional.empty();
-    private Optional<SubscribeRateLimiter> subscribeRateLimiter = Optional.empty();

Review comment:
       This can uniform the limiters to `AbstractTopic` and we can update it like [updateSubscribeRate](https://github.com/apache/pulsar/pull/14890/files?diff=split&w=0#diff-0210356c8a88e4efa89eb769a027fa6c166db479dbad8bbbbc704c6ed6e317f5R2337)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org