You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2023/04/22 10:56:32 UTC

[GitHub] [hudi] huangxiaopingRD opened a new pull request, #8543: [HUDI-6124] Optimize exception message for init HoodieCatalogTable assert

huangxiaopingRD opened a new pull request, #8543:
URL: https://github.com/apache/hudi/pull/8543

   …sert
   
   ### Change Logs
   
   Optimize exception message for init HoodieCatalogTable assert
   
   ### Impact
   
   No
   ### Risk level (write none, low medium or high below)
   
   None
   ### Documentation Update
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bvaradar commented on a diff in pull request #8543: [HUDI-6124] Optimize exception message in HoodieCatalogTable

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.

bvaradar commented on code in PR #8543:
URL: https://github.com/apache/hudi/pull/8543#discussion_r1175652747


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -1065,4 +1065,21 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
       }
     }
   }
+
+  test("Test init HoodieCatalogTable class for non-Hudi table") {
+    val tableName = generateTableName
+    spark.sql(
+      s"""
+         | create table $tableName (
+         |  id int,
+         |  name string,
+         |  price double,
+         |  ts long
+         | ) using parquet
+       """.stripMargin)
+    val exception = intercept[IllegalArgumentException] {
+      spark.sql(s"""call show_commits(table => '$tableName', limit => 10)""").collect()
+    }
+    assert(exception.getMessage.contains(s"""$tableName is not a Hudi table"""))

Review Comment:
   use assertTrue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bvaradar commented on a diff in pull request #8543: [HUDI-6124] Optimize exception message for init HoodieCatalogTable assert

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.

bvaradar commented on code in PR #8543:
URL: https://github.com/apache/hudi/pull/8543#discussion_r1174474333


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/catalyst/catalog/HoodieCatalogTable.scala:
##########
@@ -51,7 +50,7 @@ import scala.collection.mutable
  */
 class HoodieCatalogTable(val spark: SparkSession, var table: CatalogTable) extends Logging {
 
-  assert(table.provider.map(_.toLowerCase(Locale.ROOT)).orNull == "hudi", "It's not a Hudi table")
+  assert(table.provider.map(_.toLowerCase(Locale.ROOT)).orNull == "hudi", s" ${table.qualifiedName} is not a Hudi table")

Review Comment:
   Can you replace all asserts with ValidationUtils.checkArgument in this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org