You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/07/02 05:53:23 UTC
Re: Review Request 70886: Override source address for executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70886/#review216302
-----------------------------------------------------------
Bad review!
Reviews applied: [70886, 70933, 70797, 70921, 70795, 70749, 70884, 70883, 70810, 70748]
Error:
2019-07-02 05:53:22 URL:https://reviews.apache.org/r/70749/diff/raw/ [21255/21255] -> "70749.patch" [1]
error: patch failed: 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp:548
error: 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp: patch does not apply
- Mesos Reviewbot
On June 19, 2019, 7:48 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70886/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 7:48 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jan-Philip Gehrcke, Joseph Wu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ignore an executor's reported IP address and enforce the hostname
> "localhost" instead.
>
> This is intended to enable TLS connections to executors running
> in bridge-mode or virtual-mode docker containers, which can not
> present a valid certificate containing their source IP which is
> dynamically generated and not known until the executor connects.
>
> NOTE: This change is for illustration purposes only, and is not
> intended to be upstreamed.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/70886/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>