[GitHub] [beam] scwhittle commented on a diff in pull request #17191: [BEAM-14157] GrpcWindmillServer: Use stream specific boolean to do client closed check

[GitBox <gi...@apache.org>]

scwhittle commented on code in PR #17191:
URL: https://github.com/apache/beam/pull/17191#discussion_r841497489


##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServerTest.java:
##########
@@ -491,11 +493,96 @@ private WorkItemCommitRequest makeCommitRequest(int i, int size) {
         .build();
   }
 
+  // This server receives WorkItemCommitRequests, and verifies they are equal to the above

Review Comment:
   s/above commitRequest/provided commitRequests/



##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServerTest.java:
##########
@@ -613,11 +694,14 @@ public void onCompleted() {
       }
     }
     stream.flush();
+    stream.close();
+
+    Thread.sleep(100);

Review Comment:
   Instead of just sleeping could you poll some counter you increment when returning server errors, and wait for a couple errors to be returned?  That would help ensure the error handling path on the client actually runs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org