[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6424: Make Pinot JDK 11 Compilable

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #6424:
URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-859772614


   > > LGTM. My only concern is how do we ensure the tests can pass in java 8? We still want to keep java 8 supported
   > 
   > We want to keep java 8 support, so we keep the quickstart test for java 8, but no unit tests or integration tests.
   > 
   > Also, this setup blocks using the code feature of java 11.
   
   If we use the code feature of java 11, we can no longer support compiling in java 8 right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org