You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ti...@sastau.it> on 2007/12/19 18:06:10 UTC
Re: svn commit: r605608 - /ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
Anil,
if the GL auto posting services are still causing issues (because they
are in alpha and because seed data is not completely implemented) we can
disable them all in the accounting/ofbiz-component.xml file.
I was the one that activated them all some time ago, but maybe it was
too early.
Jacopo
apatel@apache.org wrote:
> Author: apatel
> Date: Wed Dec 19 08:34:06 2007
> New Revision: 605608
>
> URL: http://svn.apache.org/viewvc?rev=605608&view=rev
> Log:
> Sorry, I saw Jacopo's comments from his earlier commit. Instead I need to fix seed data in my app.
>
> Modified:
> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>
> Modified: ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml?rev=605608&r1=605607&r2=605608&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml (original)
> +++ ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml Wed Dec 19 08:34:06 2007
> @@ -78,12 +78,10 @@
> <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
> </eca>
> <!--attempt to create AcctgTrans and Entries for Incoming Payment -->
> - <!-- Uncomment this entry if GL data is setup.
> <eca service="createPayment" event="commit">
> <condition field-name="statusId" operator="equals" value="PMNT_RECEIVED"/>
> <action service="createAcctgTransAndEntriesForIncomingPayment" mode="sync"/>
> </eca>
> - -->
> <!--attempt to create AcctgTrans and Entries for Incoming when set PaymentStatus -->
> <eca service="setPaymentStatus" event="commit">
> <condition field-name="statusId" operator="equals" value="PMNT_RECEIVED"/>
>
Re: svn commit: r605608 - /ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
Posted by Jacopo Cappellato <ti...@sastau.it>.
Thanks.
By the way, if it is going to be too complex, of course we can also run
all the GL auto posting services with the "system" user.
Jacopo
Adrian Crum wrote:
> Jacopo,
>
> I looked at that example. You have things set up a little differently
> than I pictured. I'll get back to you in a little while.
>
> -Adrian
>
> Jacopo Cappellato wrote:
>
>> Adrian,
>>
>> thanks for the details; I'd say that an example for one of the auto
>> posting services (for example
>> "createAcctgTransForSalesShipmentIssuance") that are triggered by
>> 'external' actions by the secas defined in secas_ledger.xml would
>> really help.
>>
>> Jacopo
>>
>>
>> Adrian Crum wrote:
>>
>>>
>>> Ideally, external apps posting to GL wouldn't need to assign any
>>> additional permissions to the user. The permission SECAs decision
>>> would be based on the validity of the data in the transaction, not on
>>> the user's permissions.
>>>
>>> -Adrian
>>>
>>> Anil Patel wrote:
>>>
>>>> Jacopo,
>>>> I think I'll first try to fix data in my app and see if its possible to
>>>> live with it. I understand, Its important to keep these services active
>>>> in order to get it tested better.
>>>>
>>>> Regards
>>>> Anil Patel
>>>>
>>>> On Wed, 2007-12-19 at 18:06 +0100, Jacopo Cappellato wrote:
>>>>
>>>>> Anil,
>>>>>
>>>>> if the GL auto posting services are still causing issues (because
>>>>> they are in alpha and because seed data is not completely
>>>>> implemented) we can disable them all in the
>>>>> accounting/ofbiz-component.xml file.
>>>>> I was the one that activated them all some time ago, but maybe it
>>>>> was too early.
>>>>>
>>>>> Jacopo
>>>>>
>>>>>
>>>>> apatel@apache.org wrote:
>>>>>
>>>>>> Author: apatel
>>>>>> Date: Wed Dec 19 08:34:06 2007
>>>>>> New Revision: 605608
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=605608&view=rev
>>>>>> Log:
>>>>>> Sorry, I saw Jacopo's comments from his earlier commit. Instead I
>>>>>> need to fix seed data in my app.
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml?rev=605608&r1=605607&r2=605608&view=diff
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>> ---
>>>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>>> (original)
>>>>>> +++
>>>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>>> Wed Dec 19 08:34:06 2007
>>>>>> @@ -78,12 +78,10 @@
>>>>>> <action
>>>>>> service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>>>>>> </eca>
>>>>>> <!--attempt to create AcctgTrans and Entries for Incoming
>>>>>> Payment -->
>>>>>> - <!-- Uncomment this entry if GL data is setup. <eca
>>>>>> service="createPayment" event="commit">
>>>>>> <condition field-name="statusId" operator="equals"
>>>>>> value="PMNT_RECEIVED"/>
>>>>>> <action
>>>>>> service="createAcctgTransAndEntriesForIncomingPayment" mode="sync"/>
>>>>>> </eca>
>>>>>> - -->
>>>>>> <!--attempt to create AcctgTrans and Entries for Incoming when
>>>>>> set PaymentStatus -->
>>>>>> <eca service="setPaymentStatus" event="commit">
>>>>>> <condition field-name="statusId" operator="equals"
>>>>>> value="PMNT_RECEIVED"/>
>>>>>>
>>>>>
>>>>
>>>>
>>
>>
Re: svn commit: r605608 - /ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
Posted by Adrian Crum <ad...@hlmksw.com>.
Jacopo,
I looked at that example. You have things set up a little differently than I pictured. I'll get back
to you in a little while.
-Adrian
Jacopo Cappellato wrote:
> Adrian,
>
> thanks for the details; I'd say that an example for one of the auto
> posting services (for example
> "createAcctgTransForSalesShipmentIssuance") that are triggered by
> 'external' actions by the secas defined in secas_ledger.xml would really
> help.
>
> Jacopo
>
>
> Adrian Crum wrote:
>
>>
>> Ideally, external apps posting to GL wouldn't need to assign any
>> additional permissions to the user. The permission SECAs decision
>> would be based on the validity of the data in the transaction, not on
>> the user's permissions.
>>
>> -Adrian
>>
>> Anil Patel wrote:
>>
>>> Jacopo,
>>> I think I'll first try to fix data in my app and see if its possible to
>>> live with it. I understand, Its important to keep these services active
>>> in order to get it tested better.
>>>
>>> Regards
>>> Anil Patel
>>>
>>> On Wed, 2007-12-19 at 18:06 +0100, Jacopo Cappellato wrote:
>>>
>>>> Anil,
>>>>
>>>> if the GL auto posting services are still causing issues (because
>>>> they are in alpha and because seed data is not completely
>>>> implemented) we can disable them all in the
>>>> accounting/ofbiz-component.xml file.
>>>> I was the one that activated them all some time ago, but maybe it
>>>> was too early.
>>>>
>>>> Jacopo
>>>>
>>>>
>>>> apatel@apache.org wrote:
>>>>
>>>>> Author: apatel
>>>>> Date: Wed Dec 19 08:34:06 2007
>>>>> New Revision: 605608
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=605608&view=rev
>>>>> Log:
>>>>> Sorry, I saw Jacopo's comments from his earlier commit. Instead I
>>>>> need to fix seed data in my app.
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml?rev=605608&r1=605607&r2=605608&view=diff
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>> --- ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>> (original)
>>>>> +++ ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>> Wed Dec 19 08:34:06 2007
>>>>> @@ -78,12 +78,10 @@
>>>>> <action
>>>>> service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>>>>> </eca>
>>>>> <!--attempt to create AcctgTrans and Entries for Incoming
>>>>> Payment -->
>>>>> - <!-- Uncomment this entry if GL data is setup. <eca
>>>>> service="createPayment" event="commit">
>>>>> <condition field-name="statusId" operator="equals"
>>>>> value="PMNT_RECEIVED"/>
>>>>> <action
>>>>> service="createAcctgTransAndEntriesForIncomingPayment" mode="sync"/>
>>>>> </eca>
>>>>> - -->
>>>>> <!--attempt to create AcctgTrans and Entries for Incoming when
>>>>> set PaymentStatus -->
>>>>> <eca service="setPaymentStatus" event="commit">
>>>>> <condition field-name="statusId" operator="equals"
>>>>> value="PMNT_RECEIVED"/>
>>>>>
>>>>
>>>
>>>
>
>
Re: svn commit: r605608 - /ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
Posted by Jacopo Cappellato <ti...@sastau.it>.
Adrian,
thanks for the details; I'd say that an example for one of the auto
posting services (for example
"createAcctgTransForSalesShipmentIssuance") that are triggered by
'external' actions by the secas defined in secas_ledger.xml would really
help.
Jacopo
Adrian Crum wrote:
>
> Ideally, external apps posting to GL wouldn't need to assign any
> additional permissions to the user. The permission SECAs decision would
> be based on the validity of the data in the transaction, not on the
> user's permissions.
>
> -Adrian
>
> Anil Patel wrote:
>> Jacopo,
>> I think I'll first try to fix data in my app and see if its possible to
>> live with it. I understand, Its important to keep these services active
>> in order to get it tested better.
>>
>> Regards
>> Anil Patel
>>
>> On Wed, 2007-12-19 at 18:06 +0100, Jacopo Cappellato wrote:
>>
>>> Anil,
>>>
>>> if the GL auto posting services are still causing issues (because
>>> they are in alpha and because seed data is not completely
>>> implemented) we can disable them all in the
>>> accounting/ofbiz-component.xml file.
>>> I was the one that activated them all some time ago, but maybe it was
>>> too early.
>>>
>>> Jacopo
>>>
>>>
>>> apatel@apache.org wrote:
>>>
>>>> Author: apatel
>>>> Date: Wed Dec 19 08:34:06 2007
>>>> New Revision: 605608
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=605608&view=rev
>>>> Log:
>>>> Sorry, I saw Jacopo's comments from his earlier commit. Instead I
>>>> need to fix seed data in my app.
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml?rev=605608&r1=605607&r2=605608&view=diff
>>>>
>>>> ==============================================================================
>>>>
>>>> --- ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>> Wed Dec 19 08:34:06 2007
>>>> @@ -78,12 +78,10 @@
>>>> <action service="createAcctgTransForFixedAssetMaintIssuance"
>>>> mode="sync"/>
>>>> </eca>
>>>> <!--attempt to create AcctgTrans and Entries for Incoming
>>>> Payment -->
>>>> - <!-- Uncomment this entry if GL data is setup. <eca
>>>> service="createPayment" event="commit">
>>>> <condition field-name="statusId" operator="equals"
>>>> value="PMNT_RECEIVED"/>
>>>> <action
>>>> service="createAcctgTransAndEntriesForIncomingPayment" mode="sync"/>
>>>> </eca>
>>>> - -->
>>>> <!--attempt to create AcctgTrans and Entries for Incoming when
>>>> set PaymentStatus -->
>>>> <eca service="setPaymentStatus" event="commit">
>>>> <condition field-name="statusId" operator="equals"
>>>> value="PMNT_RECEIVED"/>
>>>>
>>>
>>
>>
Re: svn commit: r605608 - /ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
Posted by Adrian Crum <ad...@hlmksw.com>.
One more thing to keep in mind with the GL posting SECAs - I changed the permissions a little in the
accounting component.
When I worked on converting permission checking to the permission service, I kept all permissions
the same except two. One of them was called ACCOUNTING_ATX_POST or something like that. There was a
note in the seed data that the permission was used to allow other applications to post GL
transactions without having to give the user full access to the accounting component. What concerned
me was, someone using OFBiz could assign this permission to a user without fully understanding the
implications. With that permission, a user could post ANY GL transaction - not just the intended
one. So I removed the permission from the seed data and updated the notes in the seed data file. I
checked to see if the permission was actually being used in the project, but I couldn't find it
anywhere - so I assumed removing it wouldn't break anything.
The best way to handle GL posting permissions (in my opinion) is to keep the GL posting services
locked down with the ACCTG_ATX_* permissions - so that only an accountant is given those
permissions. External apps that need to post to GL can have permission service SECAs that analyze
their particular transaction to see if the user is allowed to post that transaction.
Ideally, external apps posting to GL wouldn't need to assign any additional permissions to the user.
The permission SECAs decision would be based on the validity of the data in the transaction, not on
the user's permissions.
-Adrian
Anil Patel wrote:
> Jacopo,
> I think I'll first try to fix data in my app and see if its possible to
> live with it. I understand, Its important to keep these services active
> in order to get it tested better.
>
> Regards
> Anil Patel
>
> On Wed, 2007-12-19 at 18:06 +0100, Jacopo Cappellato wrote:
>
>>Anil,
>>
>>if the GL auto posting services are still causing issues (because they
>>are in alpha and because seed data is not completely implemented) we can
>> disable them all in the accounting/ofbiz-component.xml file.
>>I was the one that activated them all some time ago, but maybe it was
>>too early.
>>
>>Jacopo
>>
>>
>>apatel@apache.org wrote:
>>
>>>Author: apatel
>>>Date: Wed Dec 19 08:34:06 2007
>>>New Revision: 605608
>>>
>>>URL: http://svn.apache.org/viewvc?rev=605608&view=rev
>>>Log:
>>>Sorry, I saw Jacopo's comments from his earlier commit. Instead I need to fix seed data in my app.
>>>
>>>Modified:
>>> ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>
>>>Modified: ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
>>>URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml?rev=605608&r1=605607&r2=605608&view=diff
>>>==============================================================================
>>>--- ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml (original)
>>>+++ ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml Wed Dec 19 08:34:06 2007
>>>@@ -78,12 +78,10 @@
>>> <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>>> </eca>
>>> <!--attempt to create AcctgTrans and Entries for Incoming Payment -->
>>>- <!-- Uncomment this entry if GL data is setup.
>>> <eca service="createPayment" event="commit">
>>> <condition field-name="statusId" operator="equals" value="PMNT_RECEIVED"/>
>>> <action service="createAcctgTransAndEntriesForIncomingPayment" mode="sync"/>
>>> </eca>
>>>- -->
>>> <!--attempt to create AcctgTrans and Entries for Incoming when set PaymentStatus -->
>>> <eca service="setPaymentStatus" event="commit">
>>> <condition field-name="statusId" operator="equals" value="PMNT_RECEIVED"/>
>>>
>>
>
>
Re: svn commit: r605608 -
/ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
Posted by Anil Patel <an...@hotwaxmedia.com>.
Jacopo,
I think I'll first try to fix data in my app and see if its possible to
live with it. I understand, Its important to keep these services active
in order to get it tested better.
Regards
Anil Patel
On Wed, 2007-12-19 at 18:06 +0100, Jacopo Cappellato wrote:
> Anil,
>
> if the GL auto posting services are still causing issues (because they
> are in alpha and because seed data is not completely implemented) we can
> disable them all in the accounting/ofbiz-component.xml file.
> I was the one that activated them all some time ago, but maybe it was
> too early.
>
> Jacopo
>
>
> apatel@apache.org wrote:
> > Author: apatel
> > Date: Wed Dec 19 08:34:06 2007
> > New Revision: 605608
> >
> > URL: http://svn.apache.org/viewvc?rev=605608&view=rev
> > Log:
> > Sorry, I saw Jacopo's comments from his earlier commit. Instead I need to fix seed data in my app.
> >
> > Modified:
> > ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
> >
> > Modified: ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml?rev=605608&r1=605607&r2=605608&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml (original)
> > +++ ofbiz/trunk/applications/accounting/servicedef/secas_ledger.xml Wed Dec 19 08:34:06 2007
> > @@ -78,12 +78,10 @@
> > <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
> > </eca>
> > <!--attempt to create AcctgTrans and Entries for Incoming Payment -->
> > - <!-- Uncomment this entry if GL data is setup.
> > <eca service="createPayment" event="commit">
> > <condition field-name="statusId" operator="equals" value="PMNT_RECEIVED"/>
> > <action service="createAcctgTransAndEntriesForIncomingPayment" mode="sync"/>
> > </eca>
> > - -->
> > <!--attempt to create AcctgTrans and Entries for Incoming when set PaymentStatus -->
> > <eca service="setPaymentStatus" event="commit">
> > <condition field-name="statusId" operator="equals" value="PMNT_RECEIVED"/>
> >
>
>