You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/12/08 22:53:06 UTC
Review Request 54546: GEODE-2193 a member is kicked out immediately
after joining
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54546/
-----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Bugs: geode-2193
https://issues.apache.org/jira/browse/geode-2193
Repository: geode
Description
-------
The problem is happening because we send a shutdown message, initiating election of a new coordinator, but the old ViewCreator is allowed to send out a view announcing a new member. The new coordinator manages to send out a new view before the old ViewCreator sends out the new member's view. Other members ignore the old ViewCreator's view because its view ID is old. Then the reject the new member because it has an old view ID and it isn't in their membership view.
initial view ID is x
new coordinator prepares view x+10
old coordinator prepares view x+1
other members install x+10, reject view x+1
new member joins in view x+1 when it receives view-prepare message
new member is rejected by other members because x+1 < x+10
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 6d782b147529d0d37a3b130e40e2a79322469fa4
Diff: https://reviews.apache.org/r/54546/diff/
Testing
-------
precheckin, new unit test, integration testing
Thanks,
Bruce Schuchardt
Re: Review Request 54546: GEODE-2193 a member is kicked out
immediately after joining
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54546/#review158705
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Dec. 8, 2016, 10:53 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54546/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 10:53 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: geode-2193
> https://issues.apache.org/jira/browse/geode-2193
>
>
> Repository: geode
>
>
> Description
> -------
>
> The problem is happening because we send a shutdown message, initiating election of a new coordinator, but the old ViewCreator is allowed to send out a view announcing a new member. The new coordinator manages to send out a new view before the old ViewCreator sends out the new member's view. Other members ignore the old ViewCreator's view because its view ID is old. Then the reject the new member because it has an old view ID and it isn't in their membership view.
>
> initial view ID is x
> new coordinator prepares view x+10
> old coordinator prepares view x+1
> other members install x+10, reject view x+1
> new member joins in view x+1 when it receives view-prepare message
> new member is rejected by other members because x+1 < x+10
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 6d782b147529d0d37a3b130e40e2a79322469fa4
>
> Diff: https://reviews.apache.org/r/54546/diff/
>
>
> Testing
> -------
>
> precheckin, new unit test, integration testing
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 54546: GEODE-2193 a member is kicked out
immediately after joining
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54546/#review158594
-----------------------------------------------------------
Fix it, then Ship it!
Fix and then ship it
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 825)
<https://reviews.apache.org/r/54546/#comment229371>
spelling "done"
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 834)
<https://reviews.apache.org/r/54546/#comment229372>
spelling "done"
- Udo Kohlmeyer
On Dec. 8, 2016, 10:53 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54546/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 10:53 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: geode-2193
> https://issues.apache.org/jira/browse/geode-2193
>
>
> Repository: geode
>
>
> Description
> -------
>
> The problem is happening because we send a shutdown message, initiating election of a new coordinator, but the old ViewCreator is allowed to send out a view announcing a new member. The new coordinator manages to send out a new view before the old ViewCreator sends out the new member's view. Other members ignore the old ViewCreator's view because its view ID is old. Then the reject the new member because it has an old view ID and it isn't in their membership view.
>
> initial view ID is x
> new coordinator prepares view x+10
> old coordinator prepares view x+1
> other members install x+10, reject view x+1
> new member joins in view x+1 when it receives view-prepare message
> new member is rejected by other members because x+1 < x+10
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 6d782b147529d0d37a3b130e40e2a79322469fa4
>
> Diff: https://reviews.apache.org/r/54546/diff/
>
>
> Testing
> -------
>
> precheckin, new unit test, integration testing
>
>
> Thanks,
>
> Bruce Schuchardt
>
>