You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/16 17:15:39 UTC

[GitHub] [skywalking-kong] dmsolr opened a new pull request #1: polish docs

dmsolr opened a new pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] wu-sheng commented on pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1#issuecomment-821736182


   Please add .asf control file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] wu-sheng merged pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] wu-sheng commented on pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1#issuecomment-821791416


   > > Please add .asf control file.
   > 
   > added.
   
   We need CI passed required and review required(1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] kezhenxu94 commented on a change in pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1#discussion_r615177899



##########
File path: README.md
##########
@@ -48,4 +55,13 @@ $ curl -X POST --url http://localhost:8001/plugins/ \
    --data 'config.sample_ratio=100' \
    --data 'config.service_name=kong'
    --data 'config.service_instance_name=kong-with-skywalking'
-```
\ No newline at end of file
+```
+
+# Contact Us
+* Submit an [issue](https://github.com/apache/skywalking/issues) with `[NIGNX-LUA]` as the issue title prefix.

Review comment:
       Wrong prefix




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] dmsolr commented on a change in pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1#discussion_r615215485



##########
File path: README.md
##########
@@ -48,4 +55,13 @@ $ curl -X POST --url http://localhost:8001/plugins/ \
    --data 'config.sample_ratio=100' \
    --data 'config.service_name=kong'
    --data 'config.service_instance_name=kong-with-skywalking'
-```
\ No newline at end of file
+```
+
+# Contact Us
+* Submit an [issue](https://github.com/apache/skywalking/issues) with `[NIGNX-LUA]` as the issue title prefix.

Review comment:
       what do you think about `KONG_LUA` as prefix?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] kezhenxu94 commented on a change in pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1#discussion_r615177665



##########
File path: README.md
##########
@@ -1,13 +1,20 @@
-Apache SkyWalking Nginx Agent For Kong
+Apache SkyWalking Kong Agent
 ==========
 
-This plugin base on Apache SkyWalking Nginx Agent for the Kong API gateway to integrate with the Apache SkyWalking distributed tracing system.
+<img src="http://skywalking.apache.org/assets/logo.svg" alt="Sky Walking logo" height="90px" align="right" />
+
+[![Twitter Follow](https://img.shields.io/twitter/follow/asfskywalking.svg?style=for-the-badge&label=Follow&logo=twitter)](https://twitter.com/AsfSkyWalking)
+
+![CI](https://github.com/apache/skywalking-nginx-lua/workflows/CI/badge.svg?branch=master)

Review comment:
       Wrong link




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] dmsolr commented on pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1#issuecomment-821775928


   > Please add .asf control file.
   
   added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-kong] wu-sheng commented on a change in pull request #1: polish docs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-kong/pull/1#discussion_r615228973



##########
File path: README.md
##########
@@ -58,10 +58,10 @@ $ curl -X POST --url http://localhost:8001/plugins/ \
 ```
 
 # Contact Us
-* Submit an [issue](https://github.com/apache/skywalking/issues) with `[NIGNX-LUA]` as the issue title prefix.
+* Submit an [issue](https://github.com/apache/skywalking/issues) with `[KONG_LUA]` as the issue title prefix.

Review comment:
       ```suggestion
   * Submit an [issue](https://github.com/apache/skywalking/issues) with `[KONG]` as the issue title prefix.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org