[jira] [Commented] (S2GRAPH-125) Add options field on Label model for controlling advanced options.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652540#comment-15652540 ] 

ASF GitHub Bot commented on S2GRAPH-125:
----------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/94

    [S2GRAPH-125]: Add options field on Label model for controlling advanced options.

    + add options variable on label model class.
    + add "skipVertex", "skipReverse" advanced options on `Label`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-125

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
    
----
commit 0e58f55722b48517f0db4a99d8e823dff4fffb2d
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-03-16T04:32:36Z

    add options variable on label model class.

commit 4bce75bc4c7822b8582503c1d4b83f80d20764fe
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-03-16T07:04:29Z

    bug fix.

commit 03af01e1928b0370a19db82b9c863abc56360e94
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-03-16T08:02:03Z

    bug fix on skipReverse options.

commit b5a44d9321c46f2d4c3296ea6d05e0198bd06e3c
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-03-29T08:34:20Z

    skip storing vertex's belongsTo property when insert edge unless label's extra option is set as {"skipVertex": false}.

commit 83ffcd5c947ddcc1e566b1134143ffe50daece77
Author: daewon <da...@apache.org>
Date:   2016-05-02T06:40:44Z

    Change default action

----


> Add options field on Label model for controlling advanced options.
> ------------------------------------------------------------------
>
>                 Key: S2GRAPH-125
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-125
>             Project: S2Graph
>          Issue Type: New Feature
>    Affects Versions: 0.2.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Minor
>              Labels: options
>             Fix For: 0.2.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Suggestion to add place holder for options per {{Label}}.
> While I was using S2Graph in production, there were many cases to control whether publishing or not publishing input request to Kafka({{WALLOG}}).
> For more detail, let me share my case.
> When I insert bulk data(or immutable data that is produced by batch processing, for example similarity matrix), I do not want to publish inserted {{Edge}} into {{WALLOG}}, since all data is duplicate from original bulk data.
> Maybe options to control publishing all/sampling/drop {{WALLOG}} per each {{EDGE}} can be helpful.
> Also the benefit of automatically(implicitly) create reverse direction index can be problematic in some case like S2GRAPH-123.
> For example, user insert edge {{a->out->101}}, then {{101<-in<-a}} also automatically created and some case, especially 101 has lots of incoming edges which means 101 is super-node, user may want to skip implicit reverse direction edge.
> I think we have no idea what other options may be necessary, so I am suggesting add {{options}} field on {{Label}} to hold advanced options. 
> In my opinion, storing {{JSON}} string(kind like config) as {{options}} make sense since it is easy to implement, but I am open to any other suggestions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)