You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/15 04:43:36 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #3202: [GOBBLIN-1361] Avoid conflicting ivysettings.xml in classpath
autumnust opened a new pull request #3202:
URL: https://github.com/apache/incubator-gobblin/pull/3202
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
https://issues.apache.org/jira/browse/GOBBLIN-1361
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
We have seen many cases that when we need to load `ivysettings.xml` from classpath, there's already one provided by pending applications (e.g. Hive has one of its jar containing the `ivysettings.xml`), it is quite tricky to avoid conflicts with existing settings file. Instead we added a new file name to be loaded in the `DownloadUtils` to avoid conflicting names with guarantee of backward-compatibility.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on pull request #3202: [GOBBLIN-1361] Avoid conflicting ivysettings.xml in classpath
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3202:
URL: https://github.com/apache/incubator-gobblin/pull/3202#issuecomment-760641685
@jack-moseley @htran1 Can you help take a look ? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3202: [GOBBLIN-1361] Avoid conflicting ivysettings.xml in classpath
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3202:
URL: https://github.com/apache/incubator-gobblin/pull/3202#issuecomment-761109886
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3202?src=pr&el=h1) Report
> Merging [#3202](https://codecov.io/gh/apache/incubator-gobblin/pull/3202?src=pr&el=desc) (9ed8eaf) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2e60f22784843b413dc08ab715d3cde886f12773?el=desc) (2e60f22) will **increase** coverage by `37.12%`.
> The diff coverage is `47.26%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3202?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3202 +/- ##
=============================================
+ Coverage 9.12% 46.24% +37.12%
- Complexity 1727 9788 +8061
=============================================
Files 2014 2019 +5
Lines 77128 77436 +308
Branches 8565 8602 +37
=============================================
+ Hits 7036 35809 +28773
+ Misses 69405 38297 -31108
- Partials 687 3330 +2643
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3202?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...trumented/extractor/InstrumentedExtractorBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5zdHJ1bWVudGVkL2V4dHJhY3Rvci9JbnN0cnVtZW50ZWRFeHRyYWN0b3JCYXNlLmphdmE=) | `46.42% <0.00%> (+46.42%)` | `14.00 <0.00> (+14.00)` | |
| [...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh) | `0.93% <0.00%> (+0.93%)` | `1.00 <0.00> (+1.00)` | |
| [.../org/apache/gobblin/metrics/event/TimingEvent.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9UaW1pbmdFdmVudC5qYXZh) | `70.00% <ø> (+70.00%)` | `15.00 <0.00> (+15.00)` | |
| [...n/service/modules/orchestration/AzkabanClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9BemthYmFuQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/modules/orchestration/AzkabanMultiCallables.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9BemthYmFuTXVsdGlDYWxsYWJsZXMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dules/orchestration/AzkabanProjectFlowsStatus.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9BemthYmFuUHJvamVjdEZsb3dzU3RhdHVzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/service/modules/orchestration/SessionHelper.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9TZXNzaW9uSGVscGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/GenericRecordBasedKafkaSchemaChangeInjector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9HZW5lcmljUmVjb3JkQmFzZWRLYWZrYVNjaGVtYUNoYW5nZUluamVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...tractor/extract/kafka/KafkaStreamingExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVN0cmVhbWluZ0V4dHJhY3Rvci5qYXZh) | `58.82% <0.00%> (+58.82%)` | `20.00 <0.00> (+20.00)` | |
| ... and [1105 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3202/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3202?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3202?src=pr&el=footer). Last update [2e60f22...f328786](https://codecov.io/gh/apache/incubator-gobblin/pull/3202?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3202: [GOBBLIN-1361] Avoid conflicting ivysettings.xml in classpath
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3202:
URL: https://github.com/apache/incubator-gobblin/pull/3202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org