[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645195#comment-16645195 ] 

ASF GitHub Bot commented on ARTEMIS-2096:
-----------------------------------------

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2361
  
    @tabish121 can you review and merge it please?


> AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
> --------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2096
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2096
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.6.3
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Major
>             Fix For: 2.7.0
>
>
> The AMQPMessage abstraction used to wrap the AMQP message section has some inconsistencies in how it manages the underlying data and the decoded AMQP section obtained from the Proton-J codec as well as issues with state being maintained in the presence of changes to the message made through the public facing Message APIs
> A refactoring of the AMQPMessage class to better utilize the proton-j codec to manage the message data and how it is parsed and re-encoded on change needs to be done to ensure no corrupt messages are sent and that we are not decoding and encoding sections of the message we are not intending to read or change on the sever (We currently can decode message bodies or footer is a few cases where we intend not to).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)