You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/12/10 07:49:21 UTC
Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-270
https://issues.apache.org/jira/browse/LENS-270
Repository: lens
Description
-------
After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
Diff: https://reviews.apache.org/r/41193/diff/
Testing
-------
Fixed test cases. mvn clean install is running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
[INFO] Lens .............................................. SUCCESS [3.609s]
[INFO] Lens API .......................................... SUCCESS [24.695s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
[INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
[INFO] Lens DB storage ................................... SUCCESS [20.342s]
[INFO] Lens Query Library ................................ SUCCESS [17.663s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
[INFO] Lens Server ....................................... SUCCESS [9:46.856s]
[INFO] Lens client ....................................... SUCCESS [32.908s]
[INFO] Lens CLI .......................................... SUCCESS [50.828s]
[INFO] Lens Examples ..................................... SUCCESS [8.110s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
[INFO] Lens Distribution ................................. SUCCESS [8.565s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
[INFO] Lens Regression ................................... SUCCESS [13.202s]
[INFO] Lens UI ........................................... SUCCESS [33.676s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:10.728s
[INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
[INFO] Final Memory: 200M/2134M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 11, 2015, noon, Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java, line 93
> > <https://reviews.apache.org/r/41193/diff/2/?file=1158822#file1158822line93>
> >
> > Instead of repeated casting by callers, extractPruneCause can return `<T extends LensException>`, and return `(T) retVal`
Sorry I meant `getLensExceptionInRewrite`. :)
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109923
-----------------------------------------------------------
On Dec. 10, 2015, 9:06 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 11, 2015, noon, Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 203
> > <https://reviews.apache.org/r/41193/diff/2/?file=1158823#file1158823line203>
> >
> > did not understand why we are changing `extractPruneCause` to `getJsonMessage`.
Seems I missed some functions of the the newly added class. Dropping the issue.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109923
-----------------------------------------------------------
On Dec. 10, 2015, 9:06 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Sushil Mohanty <su...@gmail.com>.
> On Dec. 11, 2015, 6:30 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 849
> > <https://reviews.apache.org/r/41193/diff/2/?file=1158820#file1158820line849>
> >
> > can we check whether the callers of this function are also logging the exception? If yes, this log is not needed. If no, can we convert it to log.error?
No being called, changed to log.error.
> On Dec. 11, 2015, 6:30 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java, line 49
> > <https://reviews.apache.org/r/41193/diff/2/?file=1158819#file1158819line49>
> >
> > can we use getMaxCause().compareTo(other.getMaxCause()) instead of raw subtraction.
Changed.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109923
-----------------------------------------------------------
On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 3:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109923
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java (line 49)
<https://reviews.apache.org/r/41193/#comment169629>
can we use getMaxCause().compareTo(other.getMaxCause()) instead of raw subtraction.
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 849)
<https://reviews.apache.org/r/41193/#comment169631>
can we check whether the callers of this function are also logging the exception? If yes, this log is not needed. If no, can we convert it to log.error?
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java (line 93)
<https://reviews.apache.org/r/41193/#comment169634>
Instead of repeated casting by callers, extractPruneCause can return `<T extends LensException>`, and return `(T) retVal`
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 203)
<https://reviews.apache.org/r/41193/#comment169635>
did not understand why we are changing `extractPruneCause` to `getJsonMessage`.
- Rajat Khandelwal
On Dec. 10, 2015, 9:06 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Sushil Mohanty <su...@gmail.com>.
> On Dec. 11, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java, line 48
> > <https://reviews.apache.org/r/41193/diff/2/?file=1158819#file1158819line48>
> >
> > Can you add comments about what comparision we are doing here?
Added.
> On Dec. 11, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java, line 84
> > <https://reviews.apache.org/r/41193/diff/2/?file=1158821#file1158821line84>
> >
> > Can you convert this to a lazy Getter method and use it in below method also ?
Changed.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109919
-----------------------------------------------------------
On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 3:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109919
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java (line 48)
<https://reviews.apache.org/r/41193/#comment169608>
Can you add comments about what comparision we are doing here?
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java (line 84)
<https://reviews.apache.org/r/41193/#comment169609>
Can you convert this to a lazy Getter method and use it in below method also ?
- Amareshwari Sriramadasu
On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 3:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Sushil Mohanty <su...@gmail.com>.
> On Dec. 11, 2015, 9:53 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java, lines 46-53
> > <https://reviews.apache.org/r/41193/diff/2-3/?file=1158819#file1158819line46>
> >
> > Nothing big, but the class can implement Comparable<NoCandidateFactAvailableException> and can assume same class argument in compareTo.
> >
> > It still extends LensException so compareTo(LensException) method is already present.
java.lang.Comparable cannot be inherited with different arguments: <org.apache.lens.cube.error.NoCandidateFactAvailableException> and <org.apache.lens.server.api.error.LensException>
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109943
-----------------------------------------------------------
On Dec. 11, 2015, 9:44 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 9:44 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109943
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java (lines 46 - 53)
<https://reviews.apache.org/r/41193/#comment169660>
Nothing big, but the class can implement Comparable<NoCandidateFactAvailableException> and can assume same class argument in compareTo.
It still extends LensException so compareTo(LensException) method is already present.
- Rajat Khandelwal
On Dec. 11, 2015, 3:14 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 3:14 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109942
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Dec. 11, 2015, 3:14 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 3:14 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 9:44 a.m.)
Review request for lens.
Changes
-------
Addressed review comments. Unit tests are running fine.
Bugs: LENS-270
https://issues.apache.org/jira/browse/LENS-270
Repository: lens
Description
-------
After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
Diff: https://reviews.apache.org/r/41193/diff/
Testing
-------
Fixed test cases. mvn clean install is running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
[INFO] Lens .............................................. SUCCESS [3.609s]
[INFO] Lens API .......................................... SUCCESS [24.695s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
[INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
[INFO] Lens DB storage ................................... SUCCESS [20.342s]
[INFO] Lens Query Library ................................ SUCCESS [17.663s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
[INFO] Lens Server ....................................... SUCCESS [9:46.856s]
[INFO] Lens client ....................................... SUCCESS [32.908s]
[INFO] Lens CLI .......................................... SUCCESS [50.828s]
[INFO] Lens Examples ..................................... SUCCESS [8.110s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
[INFO] Lens Distribution ................................. SUCCESS [8.565s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
[INFO] Lens Regression ................................... SUCCESS [13.202s]
[INFO] Lens UI ........................................... SUCCESS [33.676s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:10.728s
[INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
[INFO] Final Memory: 200M/2134M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 3:36 p.m.)
Review request for lens.
Changes
-------
Addressed review commnets. All unit tests are running fine.
Bugs: LENS-270
https://issues.apache.org/jira/browse/LENS-270
Repository: lens
Description
-------
After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
Diff: https://reviews.apache.org/r/41193/diff/
Testing
-------
Fixed test cases. mvn clean install is running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
[INFO] Lens .............................................. SUCCESS [3.609s]
[INFO] Lens API .......................................... SUCCESS [24.695s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
[INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
[INFO] Lens DB storage ................................... SUCCESS [20.342s]
[INFO] Lens Query Library ................................ SUCCESS [17.663s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
[INFO] Lens Server ....................................... SUCCESS [9:46.856s]
[INFO] Lens client ....................................... SUCCESS [32.908s]
[INFO] Lens CLI .......................................... SUCCESS [50.828s]
[INFO] Lens Examples ..................................... SUCCESS [8.110s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
[INFO] Lens Distribution ................................. SUCCESS [8.565s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
[INFO] Lens Regression ................................... SUCCESS [13.202s]
[INFO] Lens UI ........................................... SUCCESS [33.676s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:10.728s
[INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
[INFO] Final Memory: 200M/2134M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Sushil Mohanty <su...@gmail.com>.
> On Dec. 10, 2015, 10:48 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, line 850
> > <https://reviews.apache.org/r/41193/diff/1/?file=1158197#file1158197line850>
> >
> > Can you add NoCandidateDimAvailableException as well for dimtables ?
Sure. Will create a separate ticket to track this.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109731
-----------------------------------------------------------
On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 3:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 41193: LENS-270 : The exception thrown for no
candidate fact should contain only brief error
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41193/#review109731
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java (line 51)
<https://reviews.apache.org/r/41193/#comment169361>
Can you add unit tests for comparision?
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java (lines 52 - 55)
<https://reviews.apache.org/r/41193/#comment169360>
Seems you are doing much comparison here. If e instanceof NoCandidateFactAvailableException, then we should compare max causes of both exceptions
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 849)
<https://reviews.apache.org/r/41193/#comment169357>
Lets use slf4j style for logging
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 850)
<https://reviews.apache.org/r/41193/#comment169359>
Can you add NoCandidateDimAvailableException as well for dimtables ?
- Amareshwari Sriramadasu
On Dec. 10, 2015, 6:49 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41193/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:49 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-270
> https://issues.apache.org/jira/browse/LENS-270
>
>
> Repository: lens
>
>
> Description
> -------
>
> After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief error also it compares errors across drivers to show the appropriate one.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c9
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b7
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d16ea4c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 1fc8bc8
>
> Diff: https://reviews.apache.org/r/41193/diff/
>
>
> Testing
> -------
>
> Fixed test cases. mvn clean install is running fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s]
> [INFO] Lens .............................................. SUCCESS [3.609s]
> [INFO] Lens API .......................................... SUCCESS [24.695s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.389s]
> [INFO] Lens Cube ......................................... SUCCESS [11:16.979s]
> [INFO] Lens DB storage ................................... SUCCESS [20.342s]
> [INFO] Lens Query Library ................................ SUCCESS [17.663s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s]
> [INFO] Lens Server ....................................... SUCCESS [9:46.856s]
> [INFO] Lens client ....................................... SUCCESS [32.908s]
> [INFO] Lens CLI .......................................... SUCCESS [50.828s]
> [INFO] Lens Examples ..................................... SUCCESS [8.110s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s]
> [INFO] Lens Distribution ................................. SUCCESS [8.565s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s]
> [INFO] Lens Regression ................................... SUCCESS [13.202s]
> [INFO] Lens UI ........................................... SUCCESS [33.676s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:10.728s
> [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015
> [INFO] Final Memory: 200M/2134M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>