You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/02/21 18:59:25 UTC
[kudu-CR](branch-1.16.x) [tool] fix a command bug, cmd: kudu wal dump ...
Hello Kudu Jenkins, Abhishek Chennaka, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18260
to review the following change.
Change subject: [tool] fix a command bug, cmd: kudu wal dump ...
......................................................................
[tool] fix a command bug, cmd: kudu wal dump ...
kudu wal dump command will interrupt after reading alter schema entry.
Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0
Reviewed-on: http://gerrit.cloudera.org:8080/18169
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 9f164b3c542a2e44c963c43488b4fc5b0d0f0f65)
---
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
3 files changed, 269 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18260/1
--
To view, visit http://gerrit.cloudera.org:8080/18260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0
Gerrit-Change-Number: 18260
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR](branch-1.16.x) [tool] fix a command bug, cmd: kudu wal dump ...
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18260 )
Change subject: [tool] fix a command bug, cmd: kudu wal dump ...
......................................................................
[tool] fix a command bug, cmd: kudu wal dump ...
kudu wal dump command will interrupt after reading alter schema entry.
Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0
Reviewed-on: http://gerrit.cloudera.org:8080/18169
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 9f164b3c542a2e44c963c43488b4fc5b0d0f0f65)
Reviewed-on: http://gerrit.cloudera.org:8080/18260
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
3 files changed, 269 insertions(+), 4 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0
Gerrit-Change-Number: 18260
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR](branch-1.16.x) [tool] fix a command bug, cmd: kudu wal dump ...
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tool] fix a command bug, cmd: kudu wal dump ...
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0
Gerrit-Change-Number: 18260
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR](branch-1.16.x) [tool] fix a command bug, cmd: kudu wal dump ...
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18260 )
Change subject: [tool] fix a command bug, cmd: kudu wal dump ...
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0
Gerrit-Change-Number: 18260
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Feb 2022 21:20:44 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [tool] fix a command bug, cmd: kudu wal dump ...
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18260 )
Change subject: [tool] fix a command bug, cmd: kudu wal dump ...
......................................................................
Patch Set 1: Verified+1
unrelated test failure in ParameterizedRecoverMasterTest.TestRecoverDeadMasterSysCatalogCopy/1
--
To view, visit http://gerrit.cloudera.org:8080/18260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0
Gerrit-Change-Number: 18260
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Feb 2022 21:49:39 +0000
Gerrit-HasComments: No