You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/09/17 16:34:44 UTC

[GitHub] iilyak commented on a change in pull request #1602: Remove runtime configurability of core system components

iilyak commented on a change in pull request #1602: Remove runtime configurability of core system components
URL: https://github.com/apache/couchdb/pull/1602#discussion_r218140330
 
 

 ##########
 File path: src/couch/src/couch_httpd_vhost.erl
 ##########
 @@ -394,25 +390,23 @@ handle_config_terminate(_Server, _Reason, _State) ->
 
 load_conf() ->
     %% get vhost globals
-    VHostGlobals = re:split(config:get("httpd",
-            "vhost_global_handlers",""), "\\s*,\\s*",[{return, list}]),
+    VHostGlobals = re:split("_utils, _uuids, _session, _users", "\\s*,\\s*",
 
 Review comment:
   Did you consider hardcoding it?:
   ```
   VHostGlobals = ["_utils","_uuids","_session","_users"]
   ``` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services