You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "wasphin (via GitHub)" <gi...@apache.org> on 2026/01/01 17:43:03 UTC
[PR] Wrap absl::string_view as std::string to support protobuf v30+ (brpc)
wasphin opened a new pull request, #3187:
URL: https://github.com/apache/brpc/pull/3187
### What problem does this PR solve?
Issue Number: #3181
Problem Summary: support protobuf v30+
The breaking changes of Protobuf can be found at [November 7, 2024](https://protobuf.dev/news/2024-11-07)
### What is changed and the side effects?
Changed: wrapper all name/full_name with string copies, to not introduce details of absl.
Switching to StringPiece/string_view will require a re-design of the related parts.
Side effects:
- Performance effects: see above
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Wrap absl::string_view as std::string to support protobuf v30+ (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3187:
URL: https://github.com/apache/brpc/pull/3187#issuecomment-3704354098
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Wrap absl::string_view as std::string to support protobuf v30+ (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on code in PR #3187:
URL: https://github.com/apache/brpc/pull/3187#discussion_r2657822415
##########
src/brpc/nshead_pb_service_adaptor.cpp:
##########
@@ -19,18 +19,20 @@
#include <google/protobuf/descriptor.h> // MethodDescriptor
#include <google/protobuf/message.h> // Message
-#include "butil/time.h"
-#include "butil/iobuf.h" // butil::IOBuf
+#include "nshead_pb_service_adaptor.h"
Review Comment:
brpc/nshead_pb_service_adaptor.h
##########
src/brpc/builtin/protobufs_service.cpp:
##########
@@ -17,13 +17,16 @@
#include <google/protobuf/descriptor.h> // ServiceDescriptor
+
+#include "protobufs_service.h"
Review Comment:
brpc/builtin/protobufs_service.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Wrap absl::string_view as std::string to support protobuf v30+ (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright merged PR #3187:
URL: https://github.com/apache/brpc/pull/3187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org