You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by oknet <gi...@git.apache.org> on 2016/12/22 13:24:48 UTC
[GitHub] trafficserver pull request #1271: TS-5103: replace ua_raw_buffer_reader with...
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/1271
TS-5103: replace ua_raw_buffer_reader with ua_buffer_reader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver TS-5103
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1271.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1271
----
commit 55449bd0e907a0ed18f9c2f865231e6a73954193
Author: Oknet Xu <xu...@skyguard.com.cn>
Date: 2016-12-22T13:07:20Z
TS-5103: replace ua_raw_buffer_reader with ua_buffer_reader
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1271: TS-5103: replace ua_raw_buffer_reader with ua_buf...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1271
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1170/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1271: TS-5103: replace ua_raw_buffer_reader with ua_buf...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1271
Yes, this looks like the correct change to me. We should be checking that there is more data on the ua_buffer_reader. In this case, there should always be data on the ua_raw_buffer_reader, so we will be incorrectly blind tunneling GET requests without keep alive enabled. (I think).
We only want to flip to tunnel mode if there is data after the already parsed header which would be reflected by the ua_buffer_reader.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1271: TS-5103: replace ua_raw_buffer_reader with...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/1271
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1271: TS-5103: replace ua_raw_buffer_reader with ua_buf...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1271
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1275/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---