You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jörg Schaible <Jo...@Elsag-Solutions.com> on 2005/11/10 10:00:04 UTC

RE: [maven-proxy-dev] RE: [M2] Too heavy load for ibiblio?

Ben Walding wrote on Wednesday, November 09, 2005 9:37 PM:

> Jörg Schaible wrote:
>> Brett Porter wrote on Wednesday, November 09, 2005 12:35 AM:
>> 
>>> Just the metadata by default, but the poms can be enabled for
>>> refreshes. 
>>> 
>> 
>> Fine. This matches my patch
>> http://jira.codehaus.org/browse/MAVENPROXY-34. Metadata and
> their checksums are handled like snapshots and looked up
> again and this can be optionally activated for POMs too.
>> 
> I've applied this patch to CVS, but have not had a chance to test it.
> It all looked mostly reasonable though.

Are you sure? In CVS is nothing new this morning, you seem to have forgotten to commit .. ?!?

> I'm not m2 enabled here, so it might be a while.
>>> It'd probably be best to always reget the checksums, and if they've
>>> changed redownload the rest. 
>>> 
>> 
>> The current implementation handles each request separate, the
>> maven-proxy core has basically no idea if the requested
> file is an artifact, metadata or a checksum. It does
> basically a pattern matching for each requested URL to
> identify the different cases (static data or data to look up
> again). For a proper checksum support it would have
> internally to associate the checksum with the artifact and
> would have to know if the requested artifact is from a M1 or
> M2 repo, since M1 uses md5 checksums and M2 sha1. Not
> infeasible though ...
>> 
> 
> Checking the checksums frequently will degrade performance.
> The caches
> do have an expiry, so I'd probably prefer to just wait until
> the request
> has expired before grabbing it again (treat a checksum/pom like a
> snapshot). Determining the difference between SHA1 and MD5 is
> relatively simple - just base it on the length of the checksum
> portion.

Good idea. IMHO it is just enough to check if the checksum of an artifact has been updated and invalidate the cache for the artifact itself. If you commit the current changes I create a new JIRA issue with a patch for the checksum handling (incl. property to enable/disable it).

- Jörg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org