You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by hu...@apache.org on 2019/01/03 07:58:52 UTC
[incubator-dubbo] branch master updated: Remove unused code,
fix #3070 (#3073)
This is an automated email from the ASF dual-hosted git repository.
huxing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 6aad8da Remove unused code, fix #3070 (#3073)
6aad8da is described below
commit 6aad8dae077f47efb4c10da92b2a9605bb677e09
Author: huazhongming <cr...@gmail.com>
AuthorDate: Thu Jan 3 15:58:46 2019 +0800
Remove unused code, fix #3070 (#3073)
---
.../java/org/apache/dubbo/config/AbstractConfig.java | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
index 6394097..7f2612a 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
@@ -291,20 +291,6 @@ public abstract class AbstractConfig implements Serializable {
}
}
- /**
- * We only check boolean value at this moment.
- *
- * @param type
- * @param value
- * @return
- */
- private static boolean isTypeMatch(Class<?> type, String value) {
- if ((type == boolean.class || type == Boolean.class)
- && !("true".equals(value) || "false".equals(value))) {
- return false;
- }
- return true;
- }
protected static void checkExtension(Class<?> type, String property, String value) {
checkName(property, value);
@@ -565,7 +551,7 @@ public abstract class AbstractConfig implements Serializable {
config.addProperties(getMetaData());
if (Environment.getInstance().isConfigCenterFirst()) {
// The sequence would be: SystemConfiguration -> ExternalConfiguration -> AppExternalConfiguration -> AbstractConfig -> PropertiesConfiguration
- compositeConfiguration.addConfiguration(3,config);
+ compositeConfiguration.addConfiguration(3, config);
} else {
// The sequence would be: SystemConfiguration -> AbstractConfig -> ExternalConfiguration -> AppExternalConfiguration -> PropertiesConfiguration
compositeConfiguration.addConfiguration(1, config);