[GitHub] [rocketmq-spring] snicoll commented on a change in pull request #171: [ISSUE #8] Offer a more user-friendly format to configure nameserver

[GitBox <gi...@apache.org>]

snicoll commented on a change in pull request #171: [ISSUE #8] Offer a more user-friendly format to configure nameserver
URL: https://github.com/apache/rocketmq-spring/pull/171#discussion_r346705067
 
 

 ##########
 File path: rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/autoconfigure/RocketMQProperties.java
 ##########
 @@ -17,20 +17,20 @@
 
 package org.apache.rocketmq.spring.autoconfigure;
 
-import org.apache.rocketmq.common.MixAll;
-import org.springframework.boot.context.properties.ConfigurationProperties;
-
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
+import org.apache.rocketmq.common.MixAll;
+import org.springframework.boot.context.properties.ConfigurationProperties;
 
 @SuppressWarnings("WeakerAccess")
 @ConfigurationProperties(prefix = "rocketmq")
 public class RocketMQProperties {
 
     /**
-     * The name server for rocketMQ, formats: `host:port;host:port`.
+     * The name servers for rocketMQ, formats: `host:port,host:port`.
      */
-    private String nameServer;
+    private List<String> nameServer;
 
 Review comment:
   The name seems a bit odd for a collections. Have you considered naming that `servers` ? If you want to retain backward compatibility, you could deprecate this one with a replacement metadata to `servers` and then apply the old logic if `nameServer` is set. If both are set, I would throw an exception.
   
   You could then remove `nameServer` in the next feature release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services