You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org> on 2019/02/09 01:05:09 UTC

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04 

hector.acosta@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12421


Change subject: Update toolchain to support ubuntu 18.04
......................................................................

Update toolchain to support ubuntu 18.04

Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 16 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/12421/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 5: Code-Review+1

LGTM.


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 5
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 16:24:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2114/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 5
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 23:48:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................

Update toolchain to support ubuntu 18.04

Openldap was bumped because it gained openssl 1.1 support, which is what
ubuntu 18 uses.

Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Reviewed-on: http://gerrit.cloudera.org:8080/12421
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 9 insertions(+), 8 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 8
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3775/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 7
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 18:13:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/2102/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 3
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 19:35:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 6
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 18:12:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Philip Zeyliger, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12421

to look at the new patch set (#6).

Change subject: Update toolchain to support ubuntu 18.04
......................................................................

Update toolchain to support ubuntu 18.04

Openldap was bumped because it gained openssl 1.1 support, which is what
ubuntu 18 uses.

Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/12421/6
-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 6
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Looks OK as long as it builds.
The typo in bootstrap_toolchain.py looks concerning though.

http://gerrit.cloudera.org:8080/#/c/12421/2/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/12421/2/bin/bootstrap_toolchain.py@79
PS2, Line 79: 6
Shouldn't this be eighteen?



-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 18:21:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 5:

I have also built this version using internal automation. A straight build on CentOS 7 and a test-with-docker.py with --base-image=centos:6 both worked OK in core mode, except for IMPALA-8193 being triggered in the latter case.


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 5
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 16:30:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Philip Zeyliger, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12421

to look at the new patch set (#3).

Change subject: Update toolchain to support ubuntu 18.04
......................................................................

Update toolchain to support ubuntu 18.04

Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/12421/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 3
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2094/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 02:50:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12421

to look at the new patch set (#2).

Change subject: Update toolchain to support ubuntu 18.04
......................................................................

Update toolchain to support ubuntu 18.04

Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/12421/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2055/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 02:00:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
hector.acosta@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12421/2/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/12421/2/bin/bootstrap_toolchain.py@79
PS2, Line 79: 8
> Shouldn't this be eighteen?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 3
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 18:55:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 7
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 22:15:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Philip Zeyliger, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12421

to look at the new patch set (#5).

Change subject: Update toolchain to support ubuntu 18.04
......................................................................

Update toolchain to support ubuntu 18.04

Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/12421/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 5
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 1: Code-Review+2

This is fine by me.


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 20:17:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 6
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 16:44:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Update toolchain to support ubuntu 18.04

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12421 )

Change subject: Update toolchain to support ubuntu 18.04
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25c8cb129c6817a2e116f31853ae64c5a8acfe9
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 7
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 18:13:06 +0000
Gerrit-HasComments: No