You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/10 06:38:15 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #844: ORC-930: Ignore unsupported JSON x ZSTD combination in bench

dongjoon-hyun opened a new pull request #844:
URL: https://github.com/apache/orc/pull/844


   ### What changes were proposed in this pull request?
   
   This PR aims to ignore unsupported JSON x ZSTD combination in bench.
   
   ### Why are the changes needed?
   
   ```
   $ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data -d sales -c zstd -s 1
   Processing sales [avro, json, orc, parquet]
   [WARN ] Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
   Exception in thread "main" java.lang.IllegalArgumentException: Unhandled kind ZSTD
   ```
   
   ### How was this patch tested?
   
   Manually.
   
   ```
   $ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data -d sales -c zstd -s 1
   Processing sales [avro, json, orc, parquet]
   ```
   
   ```
   $ java -jar core/target/orc-benchmarks-core-*-uber.jar scan data -d sales -c zstd
   [WARN ] Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
   data/generated/sales/avro.zstd rows: 1 batches: 1
   data/generated/sales/orc.zstd rows: 1 batches: 1
   data/generated/sales/parquet.zstd rows: 1 batches: 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #844: ORC-930: Ignore unsupported JSON x ZSTD combination in bench

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896192907


   I updated my branch, but it seems that GitHub outage resets the change from this PR.
   - https://github.com/dongjoon-hyun/orc/tree/ORC-930


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #844: ORC-930: Ignore unsupported JSON x ZSTD combination in bench

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #844:
URL: https://github.com/apache/orc/pull/844


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #844: ORC-930: Ignore unsupported JSON x ZSTD combination in bench

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896214316


   I added an empty commit to recover from the data loss during GitHub outage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #844: ORC-930: Ignore unsupported JSON x ZSTD combination in bench

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896299804


   I'll merge this, @pgaref ~ :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #844: ORC-930: Ignore unsupported JSON x ZSTD combination in bench

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896121276


   Thank you for review, @pgaref !
   For the `Scan`, it looks okay to ignore it because the file doesn't exist.
   For the `Generator`, I'll try to add a message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org