[GitHub] [hudi] vinothchandar commented on a change in pull request #2200: [HUDI-912]Refactor and relocate KeyGenerator to support more engines

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #2200:
URL: https://github.com/apache/hudi/pull/2200#discussion_r514763942



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/BootstrapCommand.java
##########
@@ -68,7 +68,7 @@ public String bootstrap(
           help = "Bootstrap Index Class") final String bootstrapIndexClass,
       @CliOption(key = {"selectorClass"}, unspecifiedDefaultValue = "org.apache.hudi.client.bootstrap.selector.MetadataOnlyBootstrapModeSelector",
           help = "Selector class for bootstrap") final String selectorClass,
-      @CliOption(key = {"keyGeneratorClass"}, unspecifiedDefaultValue = "org.apache.hudi.keygen.SimpleKeyGenerator",
+      @CliOption(key = {"keyGeneratorClass"}, unspecifiedDefaultValue = "org.apache.hudi.keygen.SparkSimpleKeyGenerator",

Review comment:
       This is what I meant in the first comment. we have to be backwards compatible with existing clients. It will be disruptive change for everyone to reconfigure all their jobs. Can we avoid renaming of keygenerator classes or changing their package names




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org