[GitHub] [mynewt-nimble] KKopyscinski commented on a change in pull request #1111: Fix Coverity issues in mesh

[GitBox <gi...@apache.org>]

KKopyscinski commented on a change in pull request #1111:
URL: https://github.com/apache/mynewt-nimble/pull/1111#discussion_r759388206



##########
File path: nimble/host/mesh/src/proxy_srv.c
##########
@@ -429,7 +431,7 @@ static int node_id_adv(struct bt_mesh_subnet *sub, int32_t duration)
 	memcpy(proxy_svc_data + 3, tmp + 8, 8);
 
 	err = bt_mesh_adv_start(&fast_adv_param, duration, node_id_ad,
-			      ARRAY_SIZE(node_id_ad), sd, 0);
+                            ARRAY_SIZE(node_id_ad), sd, sd_len);

Review comment:
       Now that I look at it, I see that it just passes `sd` into `bt_le_adv_start` - so I think yes, it already accepts NULL and this is false positive




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org