You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/06/03 02:24:02 UTC
Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
-----------------------------------------------------------
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Bugs: AURORA-445
https://issues.apache.org/jira/browse/AURORA-445
Repository: aurora
Description
-------
Adding SLA check into perform_maintenance_hosts command with the possibility of override.
Diffs
-----
src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
-------
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 4, 2014, 1:37 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 14
> > <https://reviews.apache.org/r/22167/diff/2/?file=602083#file602083line14>
> >
> > This really needs some doc comments. I can figure out what individual functions do, but I have no idea how they fit in.
Added.
> On June 4, 2014, 1:37 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 86
> > <https://reviews.apache.org/r/22167/diff/2/?file=602084#file602084line86>
> >
> > You've got an identical "print_results" function in utils. Why?
That's a refactoring leftover. Removed.
> On June 4, 2014, 1:37 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, line 96
> > <https://reviews.apache.org/r/22167/diff/2/?file=602089#file602089line96>
> >
> > I don't understand this replacement: why did you get rid of the post-drain stuff?
It got moved into parse_script() function in admin_util.py for consistency with other "parse" methods.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review44684
-----------------------------------------------------------
On June 3, 2014, 12:26 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 12:26 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
> src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
> src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
> src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review44684
-----------------------------------------------------------
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment79149>
This really needs some doc comments. I can figure out what individual functions do, but I have no idea how they fit in.
src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/22167/#comment79150>
You've got an identical "print_results" function in utils. Why?
src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/22167/#comment79151>
I don't understand this replacement: why did you get rid of the post-drain stuff?
- Mark Chu-Carroll
On June 2, 2014, 8:26 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 8:26 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
> src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
> src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
> src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
> On June 9, 2014, 4:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, line 72
> > <https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72>
> >
> > This help line is unclear: what does "time interval for the percentage of up tasks" mean? The time period over which a certain percentage of tasks must have been up all the time? Time period over which a percentage of tasks must have been up for at least some amount of time?
> >
>
> Maxim Khutornenko wrote:
> The override comments here are intentionally vague to discourage their use :) Whoever is trying to override them must already have an intimate knowledge of admin sla_* commands providing, hopefully, clear instructions.
Ah, I didn't realize that. Maybe even be explicit about it: "Don't change this unless you're an expert". Although that would probably actually encourage people!
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45131
-----------------------------------------------------------
On June 9, 2014, 6:08 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 6:08 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py f223c5e90871d6f49f68fd0a93030ec785ad2c95
> src/main/python/apache/aurora/client/base.py 6716ba642500dca0aea241d94d85a33359bfd746
> src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
> src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
> src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 88
> > <https://reviews.apache.org/r/22167/diff/3/?file=603310#file603310line88>
> >
> > You've got "parse_hosts", "parst_host_file", "parse_hosts_optional", and "parse_host_list". I have no idea why there are so many different parse functions, or what they're all for. But it sure looks like overkill.
parse_host_list and parse_host_file are private helpers used by parse_hosts and parse_hosts_optional. Prefixed with "_" to better reflect on their meaning.
> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 117
> > <https://reviews.apache.org/r/22167/diff/3/?file=603310#file603310line117>
> >
> > This needs a more descriptive name. Looking at the code, I have absolutely no idea of what the condition "not d.safe if unsafe_only else True" is supposed to mean, or what's being selected for.
Fixed and documented all public methods.
> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 86
> > <https://reviews.apache.org/r/22167/diff/3/?file=603311#file603311line86>
> >
> > This method is very unclear considering how short it is.
> >
> > What is host_groups? Why does probe_hosts return a list, where more than one element in the list is an error?
> >
> >
Added clarifications.
> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, line 72
> > <https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72>
> >
> > This help line is unclear: what does "time interval for the percentage of up tasks" mean? The time period over which a certain percentage of tasks must have been up all the time? Time period over which a percentage of tasks must have been up for at least some amount of time?
> >
The override comments here are intentionally vague to discourage their use :) Whoever is trying to override them must already have an intimate knowledge of admin sla_* commands providing, hopefully, clear instructions.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45131
-----------------------------------------------------------
On June 4, 2014, 1:46 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 1:46 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
> src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
> src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
> src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, line 72
> > <https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72>
> >
> > This help line is unclear: what does "time interval for the percentage of up tasks" mean? The time period over which a certain percentage of tasks must have been up all the time? Time period over which a percentage of tasks must have been up for at least some amount of time?
> >
>
> Maxim Khutornenko wrote:
> The override comments here are intentionally vague to discourage their use :) Whoever is trying to override them must already have an intimate knowledge of admin sla_* commands providing, hopefully, clear instructions.
>
> Mark Chu-Carroll wrote:
> Ah, I didn't realize that. Maybe even be explicit about it: "Don't change this unless you're an expert". Although that would probably actually encourage people!
Makes sense. Hardened help comments :)
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45131
-----------------------------------------------------------
On June 9, 2014, 10:08 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 10:08 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py f223c5e90871d6f49f68fd0a93030ec785ad2c95
> src/main/python/apache/aurora/client/base.py 6716ba642500dca0aea241d94d85a33359bfd746
> src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
> src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
> src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45131
-----------------------------------------------------------
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment79794>
You've got "parse_hosts", "parst_host_file", "parse_hosts_optional", and "parse_host_list". I have no idea why there are so many different parse functions, or what they're all for. But it sure looks like overkill.
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment79793>
This needs a more descriptive name. Looking at the code, I have absolutely no idea of what the condition "not d.safe if unsafe_only else True" is supposed to mean, or what's being selected for.
src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/22167/#comment79795>
This method is very unclear considering how short it is.
What is host_groups? Why does probe_hosts return a list, where more than one element in the list is an error?
src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/22167/#comment79797>
This help line is unclear: what does "time interval for the percentage of up tasks" mean? The time period over which a certain percentage of tasks must have been up all the time? Time period over which a percentage of tasks must have been up for at least some amount of time?
- Mark Chu-Carroll
On June 3, 2014, 9:46 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 9:46 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
> src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
> src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
> src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45082
-----------------------------------------------------------
Ping.
- Maxim Khutornenko
On June 4, 2014, 1:46 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 1:46 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
> src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
> src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
> src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45164
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On June 9, 2014, 6:08 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 6:08 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py f223c5e90871d6f49f68fd0a93030ec785ad2c95
> src/main/python/apache/aurora/client/base.py 6716ba642500dca0aea241d94d85a33359bfd746
> src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
> src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
> src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 11, 2014, 6:47 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 111
> > <https://reviews.apache.org/r/22167/diff/6/?file=607111#file607111line111>
> >
> > parse_hostnames
Done.
> On June 11, 2014, 6:47 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 90
> > <https://reviews.apache.org/r/22167/diff/6/?file=607111#file607111line90>
> >
> > parse_hostnames_optional
Done.
> On June 11, 2014, 6:47 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 79
> > <https://reviews.apache.org/r/22167/diff/6/?file=607111#file607111line79>
> >
> > return hostnames
Done.
> On June 11, 2014, 6:47 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 76
> > <https://reviews.apache.org/r/22167/diff/6/?file=607111#file607111line76>
> >
> > hostnames =
Done.
> On June 11, 2014, 6:47 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 75
> > <https://reviews.apache.org/r/22167/diff/6/?file=607111#file607111line75>
> >
> > _parse_hostname_list(hostname_list)
> >
> > (this is important because we also have a Hosts()[1])
> >
> > [1] https://github.com/apache/incubator-aurora/blob/master/src/main/thrift/org/apache/aurora/gen/api.thrift#L397
Done.
> On June 11, 2014, 6:47 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 36
> > <https://reviews.apache.org/r/22167/diff/6/?file=607111#file607111line36>
> >
> > I wish I could link to a better 'canonical' source, but I can't (the pep doesn't seem to cover this[1]) but any chance you can follow the pre-existing style[2] for these?
> >
> > [1] http://legacy.python.org/dev/peps/pep-0287/#docstring-significant-features
> > [2] https://github.com/apache/incubator-aurora/blob/master/src/main/python/apache/aurora/admin/host_maintenance.py#L57
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45408
-----------------------------------------------------------
On June 11, 2014, 5:04 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 5:04 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py 71f27bfd5860fd7a2bdaee68efe6b418f5f191e0
> src/main/python/apache/aurora/client/base.py 31155405ddac9d1433a316e5ca943f1a46e11472
> src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
> src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
> src/test/python/apache/aurora/admin/test_host_maintenance.py 0341d35955a312fc28dbc6c4bab3564a3beb45b5
> src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
> src/test/python/apache/aurora/client/commands/test_maintenance.py 827bd7f58f74d529fb9ac7c7c1049752b2004f19
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45408
-----------------------------------------------------------
Ship it!
cool, lgtm other than ~nits
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80253>
I wish I could link to a better 'canonical' source, but I can't (the pep doesn't seem to cover this[1]) but any chance you can follow the pre-existing style[2] for these?
[1] http://legacy.python.org/dev/peps/pep-0287/#docstring-significant-features
[2] https://github.com/apache/incubator-aurora/blob/master/src/main/python/apache/aurora/admin/host_maintenance.py#L57
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80258>
_parse_hostname_list(hostname_list)
(this is important because we also have a Hosts()[1])
[1] https://github.com/apache/incubator-aurora/blob/master/src/main/thrift/org/apache/aurora/gen/api.thrift#L397
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80255>
hostnames =
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80256>
return hostnames
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80259>
parse_hostnames_optional
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80260>
parse_hostnames
src/test/python/apache/aurora/admin/test_host_maintenance.py
<https://reviews.apache.org/r/22167/#comment80263>
doh. thanks
- Joe Smith
On June 11, 2014, 10:04 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 10:04 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py 71f27bfd5860fd7a2bdaee68efe6b418f5f191e0
> src/main/python/apache/aurora/client/base.py 31155405ddac9d1433a316e5ca943f1a46e11472
> src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
> src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
> src/test/python/apache/aurora/admin/test_host_maintenance.py 0341d35955a312fc28dbc6c4bab3564a3beb45b5
> src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
> src/test/python/apache/aurora/client/commands/test_maintenance.py 827bd7f58f74d529fb9ac7c7c1049752b2004f19
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
-----------------------------------------------------------
(Updated June 11, 2014, 7:43 p.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-445
https://issues.apache.org/jira/browse/AURORA-445
Repository: aurora
Description
-------
Adding SLA check into perform_maintenance_hosts command with the possibility of override.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
src/main/python/apache/aurora/admin/host_maintenance.py 71f27bfd5860fd7a2bdaee68efe6b418f5f191e0
src/main/python/apache/aurora/client/base.py 31155405ddac9d1433a316e5ca943f1a46e11472
src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
src/test/python/apache/aurora/admin/test_host_maintenance.py 0341d35955a312fc28dbc6c4bab3564a3beb45b5
src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
src/test/python/apache/aurora/client/commands/test_maintenance.py 827bd7f58f74d529fb9ac7c7c1049752b2004f19
src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
-------
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
-----------------------------------------------------------
(Updated June 11, 2014, 5:04 p.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
Rebased and fixed flaky test_check_status in test_host_maintenance.
Brian, Joe: please review.
Bugs: AURORA-445
https://issues.apache.org/jira/browse/AURORA-445
Repository: aurora
Description
-------
Adding SLA check into perform_maintenance_hosts command with the possibility of override.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
src/main/python/apache/aurora/admin/host_maintenance.py 71f27bfd5860fd7a2bdaee68efe6b418f5f191e0
src/main/python/apache/aurora/client/base.py 31155405ddac9d1433a316e5ca943f1a46e11472
src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
src/test/python/apache/aurora/admin/test_host_maintenance.py 0341d35955a312fc28dbc6c4bab3564a3beb45b5
src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
src/test/python/apache/aurora/client/commands/test_maintenance.py 827bd7f58f74d529fb9ac7c7c1049752b2004f19
src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
-------
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45175
-----------------------------------------------------------
Ping, Brian/Joe.
- Maxim Khutornenko
On June 9, 2014, 11:10 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 11:10 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py f223c5e90871d6f49f68fd0a93030ec785ad2c95
> src/main/python/apache/aurora/client/base.py 6716ba642500dca0aea241d94d85a33359bfd746
> src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
> src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
> src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
-----------------------------------------------------------
(Updated June 9, 2014, 11:10 p.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-445
https://issues.apache.org/jira/browse/AURORA-445
Repository: aurora
Description
-------
Adding SLA check into perform_maintenance_hosts command with the possibility of override.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
src/main/python/apache/aurora/admin/host_maintenance.py f223c5e90871d6f49f68fd0a93030ec785ad2c95
src/main/python/apache/aurora/client/base.py 6716ba642500dca0aea241d94d85a33359bfd746
src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
-------
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
-----------------------------------------------------------
(Updated June 9, 2014, 10:08 p.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-445
https://issues.apache.org/jira/browse/AURORA-445
Repository: aurora
Description
-------
Adding SLA check into perform_maintenance_hosts command with the possibility of override.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
src/main/python/apache/aurora/admin/host_maintenance.py f223c5e90871d6f49f68fd0a93030ec785ad2c95
src/main/python/apache/aurora/client/base.py 6716ba642500dca0aea241d94d85a33359bfd746
src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1
src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa
src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7
src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70
src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
-------
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 9, 2014, 7:17 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 14
> > <https://reviews.apache.org/r/22167/diff/3/?file=603310#file603310line14>
> >
> > Are you sure you uploaded the correct diff? In your reply to the review, you said you'd added docs here - but I still don't see any.
> >
Yes, this is the right diff. I thought you were asking for the module level docs. I have added a line there.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45109
-----------------------------------------------------------
On June 4, 2014, 1:46 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 1:46 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
> src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
> src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
> src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45109
-----------------------------------------------------------
src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment79777>
Are you sure you uploaded the correct diff? In your reply to the review, you said you'd added docs here - but I still don't see any.
- Mark Chu-Carroll
On June 3, 2014, 9:46 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 9:46 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-445
> https://issues.apache.org/jira/browse/AURORA-445
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
> src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
> src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
> src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
> src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
> src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
> src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
> src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
> src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
>
> Diff: https://reviews.apache.org/r/22167/diff/
>
>
> Testing
> -------
>
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
-----------------------------------------------------------
(Updated June 4, 2014, 1:46 a.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-445
https://issues.apache.org/jira/browse/AURORA-445
Repository: aurora
Description
-------
Adding SLA check into perform_maintenance_hosts command with the possibility of override.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
-------
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts
command.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
-----------------------------------------------------------
(Updated June 3, 2014, 12:26 a.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Bugs: AURORA-445
https://issues.apache.org/jira/browse/AURORA-445
Repository: aurora
Description
-------
Adding SLA check into perform_maintenance_hosts command with the possibility of override.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751
src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION
src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c
src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b
src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4
src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3
src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f
src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af
src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
-------
./pants src/tests/python:all
Thanks,
Maxim Khutornenko