You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Zheaoli (via GitHub)" <gi...@apache.org> on 2024/01/10 17:30:31 UTC
Re: [PR] feat(services/s3): Add object versioning support [incubator-opendal]
Zheaoli commented on code in PR #3943:
URL: https://github.com/apache/incubator-opendal/pull/3943#discussion_r1447705347
##########
.github/workflows/edge_test.yml:
##########
@@ -137,3 +137,37 @@ jobs:
OPENDAL_S3_BUCKET: opendal-testing
OPENDAL_S3_ROLE_ARN: arn:aws:iam::952853449216:role/opendal-testing
OPENDAL_S3_REGION: ap-northeast-1
+
+ test_s3_on_versionning_enable_bucket:
Review Comment:
> I'm mainly considering the cleanup issue. With storage services that have version control, cleanup can be more complicated. We'd have to remove every version of each file, so I hope to minimize the scope of the impact as much as possible. Since version control should not affect normal user usage, there should be no need to test the functionality of version control unless it is enabled.
>
> So, can we:
>
> 1. Add version-related test cases to the existing behavior test. In this way, we can use environment variables to skip cases that do not involve version control, based on whether version control is enabled. But it also needs to add some extra cleanup steps.
> 2. Create a separate behavior test suite(maybe like this PR, but not in edge tests) that does not affect existing tests.
The test infra would not be a problem we just need to configure the lifecycle like the following below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org