You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by kx...@apache.org on 2024/02/19 13:13:57 UTC
(doris) branch branch-2.0 updated: [fix](index compaction) Only check rowid_coversion for MOW table for now. (#31102)
This is an automated email from the ASF dual-hosted git repository.
kxiao pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 39c1d4c05bb [fix](index compaction) Only check rowid_coversion for MOW table for now. (#31102)
39c1d4c05bb is described below
commit 39c1d4c05bb7bce93c60ee10dd6b4ba5d0d81427
Author: qiye <ji...@gmail.com>
AuthorDate: Mon Feb 19 21:13:50 2024 +0800
[fix](index compaction) Only check rowid_coversion for MOW table for now. (#31102)
---
be/src/olap/compaction.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/be/src/olap/compaction.cpp b/be/src/olap/compaction.cpp
index b4b34cbacb8..a686bbbf61e 100644
--- a/be/src/olap/compaction.cpp
+++ b/be/src/olap/compaction.cpp
@@ -402,10 +402,14 @@ Status Compaction::do_compaction_impl(int64_t permits) {
RETURN_IF_ERROR(check_correctness(stats));
if (_input_row_num > 0 && stats.rowid_conversion && config::inverted_index_compaction_enable &&
- !ctx.skip_inverted_index.empty()) {
+ !ctx.skip_inverted_index.empty() &&
+ (!(_tablet->keys_type() == KeysType::UNIQUE_KEYS &&
+ !_tablet->enable_unique_key_merge_on_write()))) {
OlapStopWatch inverted_watch;
// check rowid_conversion correctness
+ // currently, only check the unique key table with merge on write enabled
+ // TODO: check the correctness of rowid_conversion for other cases, such as DUP_KEYS and MOR
Version version = _tablet->max_version();
DeleteBitmap output_rowset_delete_bitmap(_tablet->tablet_id());
std::set<RowLocation> missed_rows;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org