You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/06/08 23:46:48 UTC

Review Request 35225: Add HTB queueing discipline wrapper class

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/
-----------------------------------------------------------

Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Bugs: MESOS-2752
    https://issues.apache.org/jira/browse/MESOS-2752


Repository: mesos


Description
-------

Add HTB queueing discipline wrapper class


Diffs
-----

  src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
  src/linux/routing/queueing/htb.hpp PRE-CREATION 
  src/linux/routing/queueing/htb.cpp PRE-CREATION 
  src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 

Diff: https://reviews.apache.org/r/35225/diff/


Testing
-------

sudo make check


Thanks,

Paul Brett

Re: Review Request 35225: Add HTB queueing discipline wrapper class

Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/#review87088
-----------------------------------------------------------



src/linux/routing/queueing/htb.cpp
<https://reviews.apache.org/r/35225/#comment139365>

    These params are for fq_codel, doesn't apply for htb.


- Cong Wang


On June 8, 2015, 9:46 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35225/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 9:46 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2752
>     https://issues.apache.org/jira/browse/MESOS-2752
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add HTB queueing discipline wrapper class
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
>   src/linux/routing/queueing/htb.hpp PRE-CREATION 
>   src/linux/routing/queueing/htb.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 
> 
> Diff: https://reviews.apache.org/r/35225/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Re: Review Request 35225: Add HTB queueing discipline wrapper class

Posted by Paul Brett <pa...@twopensource.com>.

> On June 9, 2015, 5:09 p.m., Cong Wang wrote:
> > src/linux/routing/queueing/htb.hpp, line 45
> > <https://reviews.apache.org/r/35225/diff/2/?file=980905#file980905line45>
> >
> >     s/if a queueing discipline already exists/if an htb queueing discipline already exists/ ??

Could also be a qdisc of another type but I will clarify.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/#review87225
-----------------------------------------------------------


On June 8, 2015, 10:58 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35225/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 10:58 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2752
>     https://issues.apache.org/jira/browse/MESOS-2752
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add HTB queueing discipline wrapper class
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
>   src/linux/routing/queueing/htb.hpp PRE-CREATION 
>   src/linux/routing/queueing/htb.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 
> 
> Diff: https://reviews.apache.org/r/35225/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Re: Review Request 35225: Add HTB queueing discipline wrapper class

Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/#review87225
-----------------------------------------------------------



src/linux/routing/queueing/htb.hpp
<https://reviews.apache.org/r/35225/#comment139549>

    s/if a queueing discipline already exists/if an htb queueing discipline already exists/ ??



src/linux/routing/queueing/htb.hpp
<https://reviews.apache.org/r/35225/#comment139548>

    s/Return/Returns/


- Cong Wang


On June 8, 2015, 10:58 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35225/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 10:58 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2752
>     https://issues.apache.org/jira/browse/MESOS-2752
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add HTB queueing discipline wrapper class
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
>   src/linux/routing/queueing/htb.hpp PRE-CREATION 
>   src/linux/routing/queueing/htb.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 
> 
> Diff: https://reviews.apache.org/r/35225/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Re: Review Request 35225: Add HTB queueing discipline wrapper class

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/#review87290
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On June 9, 2015, 5:22 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35225/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 5:22 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2752
>     https://issues.apache.org/jira/browse/MESOS-2752
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add HTB queueing discipline wrapper class
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
>   src/linux/routing/queueing/htb.hpp PRE-CREATION 
>   src/linux/routing/queueing/htb.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 
> 
> Diff: https://reviews.apache.org/r/35225/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Re: Review Request 35225: Add HTB queueing discipline wrapper class

Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/
-----------------------------------------------------------

(Updated June 9, 2015, 5:22 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Changes
-------

Clarify comments per reviewer comments.


Bugs: MESOS-2752
    https://issues.apache.org/jira/browse/MESOS-2752


Repository: mesos


Description
-------

Add HTB queueing discipline wrapper class


Diffs (updated)
-----

  src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
  src/linux/routing/queueing/htb.hpp PRE-CREATION 
  src/linux/routing/queueing/htb.cpp PRE-CREATION 
  src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 

Diff: https://reviews.apache.org/r/35225/diff/


Testing
-------

sudo make check


Thanks,

Paul Brett

Re: Review Request 35225: Add HTB queueing discipline wrapper class

Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/
-----------------------------------------------------------

(Updated June 8, 2015, 10:58 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Changes
-------

Implement reviewers comment


Bugs: MESOS-2752
    https://issues.apache.org/jira/browse/MESOS-2752


Repository: mesos


Description
-------

Add HTB queueing discipline wrapper class


Diffs (updated)
-----

  src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
  src/linux/routing/queueing/htb.hpp PRE-CREATION 
  src/linux/routing/queueing/htb.cpp PRE-CREATION 
  src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 

Diff: https://reviews.apache.org/r/35225/diff/


Testing
-------

sudo make check


Thanks,

Paul Brett