You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2025/08/26 21:50:30 UTC
[PR] [SPARK-53390][PS] Test astype with more int dtypes [spark]
xinrong-meng opened a new pull request, #52133:
URL: https://github.com/apache/spark/pull/52133
### What changes were proposed in this pull request?
Test astype with more int dtypes
### Why are the changes needed?
Part of https://issues.apache.org/jira/browse/SPARK-53005
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Test change only
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53390][PS] Raise error when bools with None `astype` to ints under ANSI [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng closed pull request #52133: [SPARK-53390][PS] Raise error when bools with None `astype` to ints under ANSI
URL: https://github.com/apache/spark/pull/52133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53390][PS] Raise error when bools with None `astype` to ints under ANSI [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #52133:
URL: https://github.com/apache/spark/pull/52133#discussion_r2302313806
##########
python/pyspark/pandas/data_type_ops/boolean_ops.py:
##########
@@ -321,6 +322,13 @@ def astype(self, index_ops: IndexOpsLike, dtype: Union[str, type, Dtype]) -> Ind
),
)
else:
+ is_ansi = is_ansi_mode_enabled(index_ops._internal.spark_frame.sparkSession)
+ if is_ansi and get_option("compute.eager_check"):
+ if is_integer_dtype(dtype) and not isinstance(dtype, extension_dtypes):
+ if index_ops.hasnans:
+ raise ValueError(
Review Comment:
Consistent with https://github.com/apache/spark/blob/master/python/pyspark/pandas/data_type_ops/num_ops.py#L552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53390][PS] Raise error when bools with None `astype` to ints under ANSI [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #52133:
URL: https://github.com/apache/spark/pull/52133#issuecomment-3229620046
Merged to master thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org