[jira] [Commented] (FLINK-3570) Replace random NIC selection heuristic by InetAddress.getLocalHost

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240955#comment-15240955 ] 

ASF GitHub Bot commented on FLINK-3570:
---------------------------------------

GitHub user fpompermaier opened a pull request:

    https://github.com/apache/flink/pull/1884

    Improved JDBCInputFormat (FLINK-3570), fixed test Exceptions in the

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [X ] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [ X] Documentation (missing web site)
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    @AfterClass due to unclosed resources and removed unnecessary close()

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fpompermaier/flink FLINK-3570

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1884
    
----
commit f9370c5414b1ebfec0210668259fc3747bc6e928
Author: Flavio Pompermaier <f....@gmail.com>
Date:   2016-04-14T10:06:18Z

    Improved JDBCInputFormat (FLINK-3570), fixed test Exceptions in the
    @AfterClass due to unclosed resources and removed unnecessary close()

----


> Replace random NIC selection heuristic by InetAddress.getLocalHost
> ------------------------------------------------------------------
>
>                 Key: FLINK-3570
>                 URL: https://issues.apache.org/jira/browse/FLINK-3570
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.1.0, 1.0.1
>
>
> Currently, the {{ConnectionUtils.findAddressUsingStrategy}} method returns the first {{NetworkInterface}} whose address is not a loop back address, not a link local address and an {{Inet4Address}}. Before returning this address, it is retried to connect to the {{JobManager}} using the {{InetAddress.getLocalHost}} address a last time.
> The heuristic, if not choosing the {{InetAddress.getLocalHost}}, often makes no sense because it returns a random {{NetworkInterface}} address. It would be better to simply return the {{InetAddress.getLocalHost()}} instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)