You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/10/09 09:25:07 UTC
[GitHub] codecov-io commented on issue #455: SCB-949 Support access distinct
kubernetes clusters
codecov-io commented on issue #455: SCB-949 Support access distinct kubernetes clusters
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/455#issuecomment-428123410
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455?src=pr&el=h1) Report
> Merging [#455](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/500b64f106732688e79bde736a6b6aaceb95fdab?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `93.87%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #455 +/- ##
=========================================
+ Coverage 60.18% 60.2% +0.02%
=========================================
Files 156 156
Lines 13404 13405 +1
=========================================
+ Hits 8067 8071 +4
+ Misses 4761 4759 -2
+ Partials 576 575 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/core/backend/addon.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9hZGRvbi5nbw==) | `100% <100%> (ø)` | |
| [server/core/backend/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jb21tb24uZ28=) | `100% <100%> (ø)` | :arrow_up: |
| [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `66.66% <100%> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: |
| [server/broker/store.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zdG9yZS5nbw==) | `93.54% <100%> (+1.88%)` | :arrow_up: |
| [server/core/backend/discovery.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kaXNjb3ZlcnkuZ28=) | `44.23% <75%> (+1.65%)` | :arrow_up: |
| [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `94.87% <0%> (-1.29%)` | :arrow_down: |
| [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <0%> (+2.63%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455?src=pr&el=footer). Last update [500b64f...11412d6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/455?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services