[jira] [Commented] (CB-1376) Exceptions of custom backbutton handlers are not returned to native code anymore

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321259#comment-16321259 ] 

ASF GitHub Bot commented on CB-1376:
------------------------------------

jcesarmobile opened a new pull request #63: CB-1376: Add build-tools-26.0.2 to travis
URL: https://github.com/apache/cordova-plugin-globalization/pull/63
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Travis
   
   ### What does this PR do?
   
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Exceptions of custom backbutton handlers are not returned to native code anymore
> --------------------------------------------------------------------------------
>
>                 Key: CB-1376
>                 URL: https://issues.apache.org/jira/browse/CB-1376
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-js, cordova-wp7 (DEFUNCT)
>    Affects Versions: Master
>            Reporter: Wolfgang Koller
>            Assignee: Filip Maj
>             Fix For: Master
>
>
> on windows phone 7 it was always possible to throw an exception in a custom backbutton handler function to trigger the default behaviour (AKA close the app).
> However since the backbutton event firing is detached in the common-js part using a setTimeout function, those exceptions are not caught by the native code anymore.
> I've already fixed this and will push the fix in a few minutes, I'm only adding this issue to document why I've done those changes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org