[GitHub] [hbase] gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#discussion_r344295314
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
 ##########
 @@ -1267,6 +1267,8 @@ HFileBlock getBlockForCaching(CacheConfig cacheConf) {
                                 .withCompressTags(fileContext.isCompressTags())
                                 .withIncludesMvcc(fileContext.isIncludesMvcc())
                                 .withIncludesTags(fileContext.isIncludesTags())
+                                .withColumnFamily(fileContext.getColumnFamily())
+                                .withTableName(fileContext.getTableName())
 
 Review comment:
   I did so in all the paths I could find where the information was readily available (primarily the main HStore flush path, and the MapReduce output format). It wasn't available in the read path, at least without larger changes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services