You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Juan F. Codagnone" <ju...@im.leak.com.ar> on 2005/10/14 06:52:33 UTC

Re: svn commit: r320827 - in /maven/components/trunk: maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/ maven-artifact-manager/src/main/java/org/apache/maven/artifact/repository/metadata/ maven-core/src/main/java/org/apache/maven/ mav...

On Thursday 13 October 2005 14:49, jdcasey@apache.org wrote:
> Author: jdcasey
> Date: Thu Oct 13 10:49:41 2005
> New Revision: 320827
...
> +    /**
> +     * Applies the server configuration to the wagon
> +     *
> +     * @param wagon the wagon to configure
> +     * @param repository the repository that has the configuration
> +     * @throws ConfigurationException if the wagon can't be configured
> +     */
> +    private void configureWagon( Wagon wagon, ArtifactRepository
> repository ) +        throws WagonConfigurationException

a small thing (but better now than ever!) there is a small typo in the throws 
doc:

Index: 
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
===================================================================
--- 
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java     
(revision 320991)
+++ 
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java     
(working copy)
@@ -697,7 +697,7 @@
      *
      * @param wagon the wagon to configure
      * @param repository the repository that has the configuration
-     * @throws ConfigurationException if the wagon can't be configured
+     * @throws WagonConfigurationException if the wagon can't be configured
      */
     private void configureWagon( Wagon wagon, ArtifactRepository repository )
         throws WagonConfigurationException


-- 
Buenos Aires, Argentina                         18°C with winds at 27 km/h ESE

Re: svn commit: r320827 - in /maven/components/trunk: maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/ maven-artifact-manager/src/main/java/org/apache/maven/artifact/repository/metadata/ maven-core/src/main/java/org/apache/maven/ mav...

Posted by "Juan F. Codagnone" <ju...@users.sourceforge.net>.
also the wagon is only configured on putRemoteFile but not in getRemoteFile. 
This was my fault and im very ashamed. Sory!!!! I will be more carefull.

Regards,
   Juan.

Index: 
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/De
faultWagonManager.java
===================================================================
--- 
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/Defau
ltWagonManager.java     (revision 320991)
+++ 
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/Defau
ltWagonManager.java     (working copy)
@@ -317,6 +317,8 @@
         try
         {
             wagon = getWagon( protocol );
+
+            configureWagon( wagon, repository );
         }
         catch ( UnsupportedProtocolException e )


On Friday 14 October 2005 01:52, Juan F. Codagnone wrote:
> On Thursday 13 October 2005 14:49, jdcasey@apache.org wrote:
> > Author: jdcasey
> > Date: Thu Oct 13 10:49:41 2005
> > New Revision: 320827
>
> ...
>
> > +    /**
> > +     * Applies the server configuration to the wagon
> > +     *
> > +     * @param wagon the wagon to configure
> > +     * @param repository the repository that has the configuration
> > +     * @throws ConfigurationException if the wagon can't be configured
> > +     */
> > +    private void configureWagon( Wagon wagon, ArtifactRepository
> > repository ) +        throws WagonConfigurationException
>
> a small thing (but better now than ever!) there is a small typo in the
> throws doc:
>
> Index:
> maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/Defa
>ultWagonManager.java
> =================================================================== ---
> maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/Defa
>ultWagonManager.java (revision 320991)
> +++
> maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/Defa
>ultWagonManager.java (working copy)
> @@ -697,7 +697,7 @@
>       *
>       * @param wagon the wagon to configure
>       * @param repository the repository that has the configuration
> -     * @throws ConfigurationException if the wagon can't be configured
> +     * @throws WagonConfigurationException if the wagon can't be
> configured */
>      private void configureWagon( Wagon wagon, ArtifactRepository
> repository ) throws WagonConfigurationException

-- 
Buenos Aires, Argentina                           16°C with winds at 11 km/h E

Re: svn commit: r320827 - in /maven/components/trunk: maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/ maven-artifact-manager/src/main/java/org/apache/maven/artifact/repository/metadata/ maven-core/src/main/java/org/apache/maven/ mav...

Posted by John Casey <jd...@commonjava.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Corrected in my local working copy. I'll commit it in just a second.

Thanks,

john

Juan F. Codagnone wrote:
| On Thursday 13 October 2005 14:49, jdcasey@apache.org wrote:
|
|>Author: jdcasey
|>Date: Thu Oct 13 10:49:41 2005
|>New Revision: 320827
|
| ...
|
|>+    /**
|>+     * Applies the server configuration to the wagon
|>+     *
|>+     * @param wagon the wagon to configure
|>+     * @param repository the repository that has the configuration
|>+     * @throws ConfigurationException if the wagon can't be configured
|>+     */
|>+    private void configureWagon( Wagon wagon, ArtifactRepository
|>repository ) +        throws WagonConfigurationException
|
|
| a small thing (but better now than ever!) there is a small typo in the
throws
| doc:
|
| Index:
|
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
| ===================================================================
| ---
|
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java

| (revision 320991)
| +++
|
maven-artifact-manager/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java

| (working copy)
| @@ -697,7 +697,7 @@
|       *
|       * @param wagon the wagon to configure
|       * @param repository the repository that has the configuration
| -     * @throws ConfigurationException if the wagon can't be configured
| +     * @throws WagonConfigurationException if the wagon can't be
configured
|       */
|      private void configureWagon( Wagon wagon, ArtifactRepository
repository )
|          throws WagonConfigurationException
|
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFDT8V8K3h2CZwO/4URAgYMAJ9I3Eh6QFqnE5giYekQjXWyBorI/ACgn+gS
EeXT5J/mO+rLyyRrpJAg7uk=
=aUEx
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org