You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/03/27 18:18:53 UTC

[PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Yicong-Huang opened a new pull request, #55063:
URL: https://github.com/apache/spark/pull/55063

   ### What changes were proposed in this pull request?
   
   Pin all `actions/*` GitHub Actions in CI workflows to specific commit SHA versions instead of mutable version tags. A version comment (e.g., `# v6`) is added alongside each SHA for maintainability.
   
   ### Why are the changes needed?
   
   Pinning actions to commit SHAs is a [security best practice recommended by GitHub](https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions) to prevent supply chain attacks via compromised action tags. Mutable tags (like `v4`, `v5`) can be moved to point to different commits, while SHA pins are immutable.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   No functional changes - only CI workflow action references are updated.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #55063: [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA
URL: https://github.com/apache/spark/pull/55063


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #55063:
URL: https://github.com/apache/spark/pull/55063#issuecomment-4152967146

   cc @dongjoon-hyun @HyukjinKwon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #55063:
URL: https://github.com/apache/spark/pull/55063#issuecomment-4157969421

   @dongjoon-hyun I see your point that this may feel like overkill. My view is that it may actually be a necessary precaution rather than overkill. In the past, we benefited from the ASF policy that allows us to trust actions under those official namespaces, but given the newer security concerns, I think it is reasonable to at least revisit that choice.
   
   Meanwhile, do you think it is reasonable to merge #55066 first? That is align with the ASF requirement to "MUST pin all external actions to the specific git hash (SHA1)". 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55063:
URL: https://github.com/apache/spark/pull/55063#issuecomment-4158000805

   Of course, I fully understand your points and appreciate your passion. But it doesn't fit with our perspectives.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #55063:
URL: https://github.com/apache/spark/pull/55063#issuecomment-4157482449

   Thanks @dongjoon-hyun for raising this concern. I also was thinking on this so I opened two PRs, one for actions internal to `apache/*, github/* and actions/*`, and another PR #55066 for thrid party actions.
   
   That said, I do not think this PR conflicts with ASF policy. 
   My understanding is that the ASF rules are also intended to improve security. They state that we **MAY** use actions under `apache/*, github/*, and actions/*` without restriction because ASF considers those namespaces validated or trusted. However, given recent software supply chain incidents, even actions under those namespaces could introduce a compromised new release without the maintainer intending it.
   This PR adds an extra safeguard by pinning those ASF-trusted actions to their SHAs, to prevent from unexpected upgrade to compromised new releases. Since ASF says we **MAY** use them without restriction, we are also free to apply a stricter rule ourselves. 
   
   I think, at this stage of AI, being a bit more cautious is probably a good thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55063:
URL: https://github.com/apache/spark/pull/55063#issuecomment-4157497515

   It seems that you don't consider this part. We already decide not to use GitHash to take advantage of ASF policy. It's over-engineering for the maintainers.
   
   > To simply put, we considered it's a little overkill to use GitHash for apache/*, github/* and actions/*, > @Yicong-Huang .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-56260][INFRA] Pin official GitHub Actions to commit SHA [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55063:
URL: https://github.com/apache/spark/pull/55063#issuecomment-4157510220

   Let me close this PR first. We can continue our discussion on the closed PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org