You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/26 10:04:46 UTC
[GitHub] [spark] attilapiros commented on issue #24080:
[SPARK-27147][TEST]Create new unit test cases for SortShuffleWriter
attilapiros commented on issue #24080: [SPARK-27147][TEST]Create new unit test cases for SortShuffleWriter
URL: https://github.com/apache/spark/pull/24080#issuecomment-476554852
@wangjiaochun I would like to kindly ask you to resolve the fixed comments (it makes easier to track what is still relevant during review).
And you do not need to force-push the same commit always. You can make as many commits as you like in your branch and that way the deltas would be visible for us too (this also helps in the review).
I think force-push is only needed when you rebase your branch onto the fresh master.
I hope these are helpful tips for your future PRs too :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org