[GitHub] [iceberg] chenjunjiedada commented on pull request #2320: Core: add delete row reader

[GitBox <gi...@apache.org>]

chenjunjiedada commented on pull request #2320:
URL: https://github.com/apache/iceberg/pull/2320#issuecomment-805414851


   Thanks @rdblue! I will update your comment in the following PR.
   
   The reason for reading deleted rows only from equality deletes is that we want to handle equality delete and position delete separately since the filtering logic and cost are different between equality delete and position delete. So that we could choose proper rewrite actions when streaming the CDC data. I'm also working on position deletes rewrite action to clustering the position deletes inside the partition, which would include a position delete row reader. Does this make sense to you?
   
   These two actions are minor compactions and @openinx have a PR that remove all delete rows which I think is major compaction. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org