You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/18 00:49:31 UTC

Review Request 12714: Remove unused 'slaves' variable from controllers.js

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12714/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

'var slaves' was unused in controllers.js.


Diffs
-----

  src/webui/master/static/js/controllers.js PRE-CREATION 

Diff: https://reviews.apache.org/r/12714/diff/


Testing
-------

Rendered each template to confirm none of them referenced the variable


Thanks,

Ross Allen

Re: Review Request 12714: Remove unused 'slaves' variable from controllers.js

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12714/#review23429
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On July 17, 2013, 10:49 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12714/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 10:49 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> 'var slaves' was unused in controllers.js.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12714/diff/
> 
> 
> Testing
> -------
> 
> Rendered each template to confirm none of them referenced the variable
> 
> 
> Thanks,
> 
> Ross Allen
> 
>